Bug 107506

Summary: [Mac] WK1 MiniBrowser should clear delegates before releasing webview
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Clear delegates in dealloc none

Joseph Pecoraro
Reported 2013-01-21 23:20:22 PST
You should always clear delegates before releasing the webview. I encountered a crash when I implemented some other UIDelegate methods for testing. We should just follow proper practice and clear delegates in dealloc.
Attachments
[PATCH] Clear delegates in dealloc (1.10 KB, patch)
2013-01-21 23:22 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-01-21 23:22:48 PST
Created attachment 183897 [details] [PATCH] Clear delegates in dealloc
WebKit Review Bot
Comment 2 2013-01-21 23:41:20 PST
Comment on attachment 183897 [details] [PATCH] Clear delegates in dealloc Clearing flags on attachment: 183897 Committed r140388: <http://trac.webkit.org/changeset/140388>
WebKit Review Bot
Comment 3 2013-01-21 23:41:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.