Bug 107506 - [Mac] WK1 MiniBrowser should clear delegates before releasing webview
Summary: [Mac] WK1 MiniBrowser should clear delegates before releasing webview
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-21 23:20 PST by Joseph Pecoraro
Modified: 2013-01-21 23:41 PST (History)
1 user (show)

See Also:


Attachments
[PATCH] Clear delegates in dealloc (1.10 KB, patch)
2013-01-21 23:22 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-01-21 23:20:22 PST
You should always clear delegates before releasing the webview. I encountered a crash when I implemented some other UIDelegate methods for testing. We should just follow proper practice and clear delegates in dealloc.
Comment 1 Joseph Pecoraro 2013-01-21 23:22:48 PST
Created attachment 183897 [details]
[PATCH] Clear delegates in dealloc
Comment 2 WebKit Review Bot 2013-01-21 23:41:20 PST
Comment on attachment 183897 [details]
[PATCH] Clear delegates in dealloc

Clearing flags on attachment: 183897

Committed r140388: <http://trac.webkit.org/changeset/140388>
Comment 3 WebKit Review Bot 2013-01-21 23:41:23 PST
All reviewed patches have been landed.  Closing bug.