Summary: | [GTK][MAC] Use CoreFoundation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | ap, benjamin, bugs-noreply, gustavo, hausmann, kevino, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Laszlo Gombos
2013-01-21 18:57:21 PST
Created attachment 183868 [details]
proposed change
Comment on attachment 183868 [details] proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=183868&action=review > Source/JavaScriptCore/ChangeLog:8 > + JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT) > + and PLATFORM(WX) so "PLATFORM(MAC)||PLATFORM(QT)||PLATFORM(WX)" is > + always true. Can Gtk port be built on Mac? (In reply to comment #2) > > Source/JavaScriptCore/ChangeLog:8 > > + JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT) > > + and PLATFORM(WX) so "PLATFORM(MAC)||PLATFORM(QT)||PLATFORM(WX)" is > > + always true. > > Can Gtk port be built on Mac? Yes. (In reply to comment #3) > (In reply to comment #2) > > > > Source/JavaScriptCore/ChangeLog:8 > > > + JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT) > > > + and PLATFORM(WX) so "PLATFORM(MAC)||PLATFORM(QT)||PLATFORM(WX)" is > > > + always true. > > > > Can Gtk port be built on Mac? > > Yes. I did not know that it is supported. In that case this is probably a performance optimization for the GTK port on Mac. Would it be possible for someone to verify this change for the GTK port on Mac ? Change the title to better reflect the functional change introduced by the patch. I cancel the review until we find someone who can help driving the GTK on MAC discussion. The larger issue here is the GTK's port policy on using CoreFoundation on OS(DARWIN). My sense is that reusing the CoreFoundation support from WebKit will make it easier to maintain the GTK MAC port, but I am not the right person to make this determination. Using CoreFoundation support from WebKit - USE(CF) - is the decision that the Qt and WX and CHROMIUM ports made on OS(DARWIN). Okay. Assuming that this doesn't change functionality, it seems pretty harmless. (In reply to comment #6) > Okay. Assuming that this doesn't change functionality, it seems pretty harmless. Likely there is a performance benefit for using CF directly. |