Bug 107473

Summary: Add build flag for Canvas's Path object (disabled by default)
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CanvasAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, gyuyoung.kim, rakuco, webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97333    
Attachments:
Description Flags
Patch none

Description Dirk Schulze 2013-01-21 13:06:15 PST 
Add build flag for Canvas's Path object (disabled by default)
Comment 1 Dirk Schulze 2013-01-21 16:17:20 PST 
Created attachment 183849 [details]
Patch
Comment 2 Dean Jackson 2013-01-21 17:25:11 PST 
Comment on attachment 183849 [details]
Patch

rs=me
Comment 3 WebKit Review Bot 2013-01-21 18:27:49 PST 
Comment on attachment 183849 [details]
Patch

Clearing flags on attachment: 183849

Committed r140377: <http://trac.webkit.org/changeset/140377>
Comment 4 WebKit Review Bot 2013-01-21 18:27:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Zan Dobersek 2013-01-22 02:59:02 PST 
For future reference, the Autotools build system has changed its guidelines about adding features. In short, no need for the configuration flags in configure.ac and Automake conditional checking in Source/WebCore/GNUmakefile.am.
More on this:
http://trac.webkit.org/wiki/AddingFeatures#ActivatingafeatureforAutotoolsbasedports

I've got a change removing these additions in bug #107537.
Comment 6 Dirk Schulze 2013-01-29 08:36:01 PST 
(In reply to comment #5)
> For future reference, the Autotools build system has changed its guidelines about adding features. In short, no need for the configuration flags in configure.ac and Automake conditional checking in Source/WebCore/GNUmakefile.am.
> More on this:
> http://trac.webkit.org/wiki/AddingFeatures#ActivatingafeatureforAutotoolsbasedports
> 
> I've got a change removing these additions in bug #107537.

Ok, thanks!