Bug 107432

Summary: [Soup] Use synchronous calls to close completely processed streams
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: danw, gns, mrobinson, rakuco, s.choi, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107439    
Attachments:
Description Flags
Patch mrobinson: review+, svillar: commit-queue-

Description Sergio Villar Senin 2013-01-21 02:01:04 PST
[Soup] Use synchronous calls to close completely processed streams
Comment 1 Sergio Villar Senin 2013-01-21 02:10:10 PST
Created attachment 183739 [details]
Patch
Comment 2 Sergio Villar Senin 2013-01-21 05:09:10 PST
We might even think about removing the close() completely as streams are automatically closed once their last reference is dropped...
Comment 3 Martin Robinson 2013-01-21 08:09:32 PST
Comment on attachment 183739 [details]
Patch

Great! Might be good to get Dan to look at this one too.
Comment 4 Dan Winship 2013-01-21 08:10:33 PST
(In reply to comment #2)
> We might even think about removing the close() completely as streams are automatically closed once their last reference is dropped...

I wouldn't recommend that, because if something was holding a ref on the stream for a while for some reason after we were done reading, that would prevent the connection from being reused for another request.
Comment 5 Sergio Villar Senin 2013-01-21 08:27:48 PST
(In reply to comment #3)
> (From update of attachment 183739 [details])
> Great! Might be good to get Dan to look at this one too.

Cool, I'll wait until we have a clear idea about what triggers the crashes I'm seeing in bug 107439 tough.
Comment 6 Sergio Villar Senin 2013-01-21 08:28:26 PST
Comment on attachment 183739 [details]
Patch

Do not land this automatically, just in case.
Comment 7 Sergio Villar Senin 2013-02-19 07:17:52 PST
Committed r143329: <http://trac.webkit.org/changeset/143329>