| Summary: | [Soup] Use synchronous calls to close completely processed streams | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | danw, gustavo, mrobinson, rakuco, s.choi, svillar, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 107439 | ||||||
| Attachments: |
|
||||||
|
Description
Sergio Villar Senin
2013-01-21 02:01:04 PST
Created attachment 183739 [details]
Patch
We might even think about removing the close() completely as streams are automatically closed once their last reference is dropped... Comment on attachment 183739 [details]
Patch
Great! Might be good to get Dan to look at this one too.
(In reply to comment #2) > We might even think about removing the close() completely as streams are automatically closed once their last reference is dropped... I wouldn't recommend that, because if something was holding a ref on the stream for a while for some reason after we were done reading, that would prevent the connection from being reused for another request. (In reply to comment #3) > (From update of attachment 183739 [details]) > Great! Might be good to get Dan to look at this one too. Cool, I'll wait until we have a clear idea about what triggers the crashes I'm seeing in bug 107439 tough. Comment on attachment 183739 [details]
Patch
Do not land this automatically, just in case.
Committed r143329: <http://trac.webkit.org/changeset/143329> |