Bug 107420

Summary:

Remove getOwnPropertyDescriptor

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

abarth, ashvayka, buildbot, cmarcelo, haraken, japhet, macpherson, menard, mkwst+watchlist, ojan.autocc, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
i love the smell of napalm in the morning	none
delete delete delete	none
revert change to enum values	buildbot: commit-queue-
Add more slot/descriptor divergence to location & history	none
Kicking another ews run!	buildbot: commit-queue-

Gavin Barraclough

Reported 2013-01-20 23:17:04 PST

This is practically redundant with getOwnPropertySlot.

Attachments
i love the smell of napalm in the morning (188.71 KB, patch) 2013-01-20 23:56 PST, Gavin Barraclough	no flags	Details Formatted Diff Diff
delete delete delete (190.90 KB, patch) 2013-01-21 00:07 PST, Gavin Barraclough	no flags	Details Formatted Diff Diff
revert change to enum values (190.90 KB, patch) 2013-01-21 00:14 PST, Gavin Barraclough	buildbot: commit-queue-	Details Formatted Diff Diff
Add more slot/descriptor divergence to location & history (192.97 KB, patch) 2013-01-22 02:49 PST, Gavin Barraclough	no flags	Details Formatted Diff Diff
Kicking another ews run! (192.97 KB, patch) 2013-01-22 03:15 PST, Gavin Barraclough	buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2013-01-20 23:56:51 PST

Created attachment 183721 [details] i love the smell of napalm in the morning

WebKit Review Bot

Comment 2 2013-01-20 23:59:33 PST

Attachment 183721 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1 Source/JavaScriptCore/runtime/PropertySlot.cpp:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/JavaScriptCore/runtime/PropertySlot.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/PropertySlot.h:37: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/runtime/PropertySlot.h:38: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/runtime/PropertySlot.h:39: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/runtime/PropertySlot.h:40: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/runtime/PropertySlot.h:41: One space before end of line comments [whitespace/comments] [5] Total errors found: 7 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gavin Barraclough

Comment 3 2013-01-21 00:07:19 PST

Created attachment 183723 [details] delete delete delete

Gavin Barraclough

Comment 4 2013-01-21 00:10:41 PST

Fixed the namespace indent & the miss indent in the .cpp. Largely retained the formatting of the enum; this is the existing formatting, and changing it makes it less readable.

Gavin Barraclough

Comment 5 2013-01-21 00:14:20 PST

Created attachment 183724 [details] revert change to enum values Tried to make enum values more sane in my last patch; forgot this will require matching script changes too – reverting for now, we can deal with this later.

Build Bot

Comment 6 2013-01-21 00:50:40 PST

Comment on attachment 183724 [details] revert change to enum values Attachment 183724 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15964903

Build Bot

Comment 7 2013-01-21 02:18:07 PST

Comment on attachment 183724 [details] revert change to enum values Attachment 183724 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15969928 New failing tests: http/tests/security/cross-frame-access-history-get.html http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html http/tests/security/cross-frame-access-object-prototype.html http/tests/security/xss-DENIED-defineProperty.html http/tests/history/cross-origin-replace-history-object-child.html

Build Bot

Comment 8 2013-01-21 03:16:51 PST

Comment on attachment 183724 [details] revert change to enum values Attachment 183724 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16011250 New failing tests: http/tests/security/cross-frame-access-object-prototype.html http/tests/history/cross-origin-replace-history-object-child.html http/tests/security/xss-DENIED-defineProperty.html

Build Bot

Comment 9 2013-01-21 04:17:07 PST

Comment on attachment 183724 [details] revert change to enum values Attachment 183724 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16035009 New failing tests: http/tests/security/cross-frame-access-object-prototype.html http/tests/history/cross-origin-replace-history-object-child.html http/tests/security/xss-DENIED-defineProperty.html

Gavin Barraclough

Comment 10 2013-01-22 02:49:21 PST

Created attachment 183945 [details] Add more slot/descriptor divergence to location & history

Gavin Barraclough

Comment 11 2013-01-22 03:15:56 PST

Created attachment 183952 [details] Kicking another ews run!

Build Bot

Comment 12 2013-01-22 03:49:54 PST

Comment on attachment 183952 [details] Kicking another ews run! Attachment 183952 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16040525

Build Bot

Comment 13 2013-01-22 05:11:50 PST

Comment on attachment 183952 [details] Kicking another ews run! Attachment 183952 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16041562 New failing tests: http/tests/security/cross-frame-access-history-get.html http/tests/security/cross-frame-access-object-prototype.html http/tests/security/xss-DENIED-defineProperty.html http/tests/history/cross-origin-replace-history-object-child.html

Build Bot

Comment 14 2013-01-22 06:04:50 PST

Comment on attachment 183952 [details] Kicking another ews run! Attachment 183952 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16045562 New failing tests: http/tests/security/cross-frame-access-history-get.html http/tests/security/cross-frame-access-object-prototype.html http/tests/security/xss-DENIED-defineProperty.html http/tests/history/cross-origin-replace-history-object-child.html

Build Bot

Comment 15 2013-01-22 19:31:44 PST

Comment on attachment 183952 [details] Kicking another ews run! Attachment 183952 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16038898 New failing tests: http/tests/security/cross-frame-access-object-prototype.html http/tests/history/cross-origin-replace-history-object-child.html http/tests/security/xss-DENIED-defineProperty.html

Darin Adler

Comment 16 2013-04-08 18:09:54 PDT

Comment on attachment 183952 [details] Kicking another ews run! Clearing flag for now. Can put up another patch for review if you return to this work.

Alexey Shvayka

Comment 17 2021-05-15 11:10:03 PDT

getOwnPropertyDescriptor() trap was removed in r154373. *** This bug has been marked as a duplicate of bug 120093 ***

Note You need to log in before you can comment on or make changes to this bug.