Bug 107419

Summary:

Web Inspector: Do not dispatch mousemove when emulating touch event and no touch is active

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, syoichi, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

107431

Bug Blocks:

Attachments:

Description	Flags
Patch	none
For EWS	none
For EWS	none
Patch for landing	none

Alexander Pavlov (apavlov)

Reported 2013-01-20 23:01:52 PST

If the point of emulate-touch-events is to let website developers verify their site works OK with a touchscreen, then it's important that we don't dispatch any mouse events. At the moment it looks like we still get mousemove events when moving the mouse cursor (tested at http://www.rbyers.net/eventTest.html). This can trigger, for example, hover menus that rely on mousemove/mouseover events, so may be impossible to trigger on a true touchscreen device, therefore leading a developer to think their site is fine when it's not. Upstreaming https://code.google.com/p/chromium/issues/detail?id=168399

Attachments
Patch (3.31 KB, patch) 2013-01-20 23:15 PST, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
For EWS (3.39 KB, patch) 2013-01-21 01:51 PST, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
For EWS (4.09 KB, patch) 2013-01-21 02:03 PST, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
Patch for landing (4.12 KB, patch) 2013-01-21 03:39 PST, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2013-01-20 23:15:50 PST

Created attachment 183717 [details] Patch

WebKit Review Bot

Comment 2 2013-01-21 00:30:04 PST

Comment on attachment 183717 [details] Patch Rejecting attachment 183717 [details] from commit-queue. New failing tests: fast/forms/number/number-spinbutton-gets-disabled-or-readonly.html fast/forms/range/slider-delete-while-dragging-thumb.html fast/forms/datalist/update-range-with-datalist.html fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events.html fast/forms/number/number-spinbutton-in-multi-column.html fast/forms/number/number-spinbutton-state.html fast/forms/number/number-spinbutton-change-and-input-events.html fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events.html fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html fast/lists/drag-into-marker.html fast/layers/no-clipping-overflow-hidden-added-after-transition.html fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events.html fast/events/touch/gesture/gesture-dblclick.html fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html fast/forms/range/slider-mouse-events.html fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html fast/events/touch/emulate-touch-events.html fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events.html fast/forms/number/number-spinbutton-click-in-iframe.html fast/events/touch/page-scaled-touch-gesture-click.html fast/forms/number/number-large-padding.html fast/events/touch/gesture/gesture-click.html fast/layers/no-clipping-overflow-hidden-added-after-transform.html fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html fast/loader/javascript-url-in-object.html fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html fast/forms/number/number-spinbutton-capturing.html fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html Full output: http://queues.webkit.org/results/15978916

Alexander Pavlov (apavlov)

Comment 3 2013-01-21 00:51:26 PST

Committed r140311: <http://trac.webkit.org/changeset/140311>

WebKit Review Bot

Comment 4 2013-01-21 01:20:18 PST

Re-opened since this is blocked by bug 107431

Alexander Pavlov (apavlov)

Comment 5 2013-01-21 01:51:40 PST

Created attachment 183735 [details] For EWS

Alexander Pavlov (apavlov)

Comment 6 2013-01-21 02:03:41 PST

Created attachment 183738 [details] For EWS

Alexander Pavlov (apavlov)

Comment 7 2013-01-21 03:39:46 PST

Created attachment 183753 [details] Patch for landing

WebKit Review Bot

Comment 8 2013-01-21 04:08:25 PST

Comment on attachment 183753 [details] Patch for landing Clearing flags on attachment: 183753 Committed r140321: <http://trac.webkit.org/changeset/140321>

WebKit Review Bot

Comment 9 2013-01-21 04:08:29 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.