Bug 107405

Summary:

Remove support getting per-resource callbacks in the UIProcess

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, cgarcia, cmarcelo, gyuyoung.kim, menard, ossy, ostap73, philn, rakuco, tmpsantos, webkit-ews, webkit.review.bot, xan.lopez, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

107421, 107417

Bug Blocks:

Attachments:

Description	Flags
Patch	andersca: review+, eflews.bot: commit-queue-
EFL, GTK & Qt build fixes after r140285.	none

Sam Weinig

Reported 2013-01-20 15:07:12 PST

Remove support getting per-resource callbacks in the UIProcess

Attachments
Patch (27.21 KB, patch) 2013-01-20 15:10 PST, Sam Weinig	andersca: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
EFL, GTK & Qt build fixes after r140285. (2.59 KB, patch) 2013-01-20 20:43 PST, Viatcheslav Ostapenko	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2013-01-20 15:10:29 PST

Created attachment 183689 [details] Patch

EFL EWS Bot

Comment 2 2013-01-20 15:14:58 PST

Comment on attachment 183689 [details] Patch Attachment 183689 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15974781

Early Warning System Bot

Comment 3 2013-01-20 15:16:48 PST

Comment on attachment 183689 [details] Patch Attachment 183689 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16011042

Anders Carlsson

Comment 4 2013-01-20 15:20:47 PST

Comment on attachment 183689 [details] Patch r=me assuming it doesn't break the nightly builds.

Sam Weinig

Comment 5 2013-01-20 17:02:59 PST

Committed r140285: <http://trac.webkit.org/changeset/140285>

Viatcheslav Ostapenko

Comment 6 2013-01-20 20:42:02 PST

Reopen because of build breaks.

Viatcheslav Ostapenko

Comment 7 2013-01-20 20:43:13 PST

Created attachment 183700 [details] EFL, GTK & Qt build fixes after r140285.

WebKit Review Bot

Comment 8 2013-01-20 21:43:38 PST

Comment on attachment 183700 [details] EFL, GTK & Qt build fixes after r140285. Clearing flags on attachment: 183700 Committed r140294: <http://trac.webkit.org/changeset/140294>

Thiago Marcos P. Santos

Comment 9 2013-01-20 22:13:53 PST

(In reply to comment #7) > Created an attachment (id=183700) [details] > EFL, GTK & Qt build fixes after r140285. Thanks for addressing the build breakage, but I'm afraid this is going to be more than just a buildsystem fix.

Carlos Garcia Campos

Comment 10 2013-01-21 08:21:26 PST

(In reply to comment #8) > (From update of attachment 183700 [details]) > Clearing flags on attachment: 183700 > > Committed r140294: <http://trac.webkit.org/changeset/140294> This is not a build fix, it removes public headers from the WebKit2 GTK+ API.

Carlos Garcia Campos

Comment 11 2013-01-21 08:25:22 PST

(In reply to comment #10) > (In reply to comment #8) > > (From update of attachment 183700 [details] [details]) > > Clearing flags on attachment: 183700 > > > > Committed r140294: <http://trac.webkit.org/changeset/140294> > > This is not a build fix, it removes public headers from the WebKit2 GTK+ API. Sorry, I misread the patch, it doesn't remove any patch from API/gtk dir. I still wonder how can this build, since GTK+ depends on WKPageResourceLoadClient. I'll look at it in detail.

Note You need to log in before you can comment on or make changes to this bug.