Bug 107403

Summary:

[BlackBerry] Improve Fatfinger phase.

Product:

WebKit

Reporter:

Tiancheng Jiang <tijiang>

Component:

UI Events

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, commit-queue, mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Tiancheng Jiang

Reported 2013-01-20 12:39:54 PST

Treat ClickableByDefault and MadeClickableByTheWebpage elements as same category. Avoid unnecessary nodes check step.

Attachments
Patch (7.40 KB, patch) 2013-01-20 13:11 PST, Tiancheng Jiang	no flags	Details Formatted Diff Diff
Patch (5.81 KB, patch) 2013-05-14 14:41 PDT, Tiancheng Jiang	no flags	Details Formatted Diff Diff
Patch (4.08 KB, patch) 2013-05-24 08:34 PDT, Tiancheng Jiang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tiancheng Jiang

Comment 1 2013-01-20 13:11:25 PST

Created attachment 183683 [details] Patch

Rob Buis

Comment 2 2013-01-20 14:52:56 PST

Comment on attachment 183683 [details] Patch LGTM, nice to see some code removal.

WebKit Review Bot

Comment 3 2013-01-20 14:57:17 PST

Comment on attachment 183683 [details] Patch Clearing flags on attachment: 183683 Committed r140282: <http://trac.webkit.org/changeset/140282>

WebKit Review Bot

Comment 4 2013-01-20 14:57:21 PST

All reviewed patches have been landed. Closing bug.

Antonio Gomes

Comment 5 2013-01-20 20:25:40 PST

This code was all added with a reason: it fixed many bugs. you removed it without any justification.

Tiancheng Jiang

Comment 6 2013-05-14 14:41:37 PDT

Reopening to attach new patch.

Tiancheng Jiang

Comment 7 2013-05-14 14:41:40 PDT

Created attachment 201761 [details] Patch

Rob Buis

Comment 8 2013-05-14 14:44:41 PDT

Comment on attachment 201761 [details] Patch Ok.

WebKit Commit Bot

Comment 9 2013-05-14 15:39:48 PDT

Comment on attachment 201761 [details] Patch Clearing flags on attachment: 201761 Committed r150091: <http://trac.webkit.org/changeset/150091>

WebKit Commit Bot

Comment 10 2013-05-14 15:39:50 PDT

All reviewed patches have been landed. Closing bug.

Tiancheng Jiang

Comment 11 2013-05-24 08:34:38 PDT

Reopening to attach new patch.

Tiancheng Jiang

Comment 12 2013-05-24 08:34:41 PDT

Created attachment 202823 [details] Patch

Antonio Gomes

Comment 13 2013-05-24 14:03:01 PDT

Comment on attachment 202823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202823&action=review > Source/WebKit/blackberry/ChangeLog:9 > + Cache the FatFinger text result for later use in TouchEventHandler. use it later when? where? what does it fix?

Tiancheng Jiang

Comment 14 2013-05-24 14:17:54 PDT

Just an idea, we do not decide how to make use of the result yet..Should I hold back this change for now? (In reply to comment #13) > (From update of attachment 202823 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202823&action=review > > > Source/WebKit/blackberry/ChangeLog:9 > > + Cache the FatFinger text result for later use in TouchEventHandler. > > use it later when? where? what does it fix?

Rob Buis

Comment 15 2013-06-14 12:40:41 PDT

(In reply to comment #14) > Just an idea, we do not decide how to make use of the result yet..Should I hold back this change for now? Antonio, let us know what you think, I'd like this to not clutter up the review queue if it is not needed.

Antonio Gomes

Comment 16 2013-06-14 15:48:42 PDT

(In reply to comment #15) > (In reply to comment #14) > > Just an idea, we do not decide how to make use of the result yet..Should I hold back this change for now? > > Antonio, let us know what you think, I'd like this to not clutter up the review queue if it is not needed. I have nothing against it, but if it is not needed so far, I would not commit it. If you guys want to go ahead, I am fine with it.

Rob Buis

Comment 17 2013-06-17 10:45:32 PDT

Comment on attachment 202823 [details] Patch Okay.

WebKit Commit Bot

Comment 18 2013-06-17 11:06:44 PDT

Comment on attachment 202823 [details] Patch Clearing flags on attachment: 202823 Committed r151648: <http://trac.webkit.org/changeset/151648>

WebKit Commit Bot

Comment 19 2013-06-17 11:06:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.