Summary: | [BlackBerry] Improve Fatfinger phase. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tiancheng Jiang <tijiang> | ||||||||
Component: | UI Events | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | allan.jensen, commit-queue, mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tiancheng Jiang
2013-01-20 12:39:54 PST
Created attachment 183683 [details]
Patch
Comment on attachment 183683 [details]
Patch
LGTM, nice to see some code removal.
Comment on attachment 183683 [details] Patch Clearing flags on attachment: 183683 Committed r140282: <http://trac.webkit.org/changeset/140282> All reviewed patches have been landed. Closing bug. This code was all added with a reason: it fixed many bugs. you removed it without any justification. Reopening to attach new patch. Created attachment 201761 [details]
Patch
Comment on attachment 201761 [details]
Patch
Ok.
Comment on attachment 201761 [details] Patch Clearing flags on attachment: 201761 Committed r150091: <http://trac.webkit.org/changeset/150091> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 202823 [details]
Patch
Comment on attachment 202823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202823&action=review > Source/WebKit/blackberry/ChangeLog:9 > + Cache the FatFinger text result for later use in TouchEventHandler. use it later when? where? what does it fix? Just an idea, we do not decide how to make use of the result yet..Should I hold back this change for now? (In reply to comment #13) > (From update of attachment 202823 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202823&action=review > > > Source/WebKit/blackberry/ChangeLog:9 > > + Cache the FatFinger text result for later use in TouchEventHandler. > > use it later when? where? what does it fix? (In reply to comment #14) > Just an idea, we do not decide how to make use of the result yet..Should I hold back this change for now? Antonio, let us know what you think, I'd like this to not clutter up the review queue if it is not needed. (In reply to comment #15) > (In reply to comment #14) > > Just an idea, we do not decide how to make use of the result yet..Should I hold back this change for now? > > Antonio, let us know what you think, I'd like this to not clutter up the review queue if it is not needed. I have nothing against it, but if it is not needed so far, I would not commit it. If you guys want to go ahead, I am fine with it. Comment on attachment 202823 [details]
Patch
Okay.
Comment on attachment 202823 [details] Patch Clearing flags on attachment: 202823 Committed r151648: <http://trac.webkit.org/changeset/151648> All reviewed patches have been landed. Closing bug. |