Bug 107391

Summary: Fix disambiguation popup for new-style page scale
Product: WebKit Reporter: Tien-Ren Chen <trchen>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, dglazkov, eric, fishd, jamesr, japhet, ojan.autocc, peter+ews, simon.fraser, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107424    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Tien-Ren Chen 2013-01-19 19:35:58 PST 
Fix disambiguation popup for new-style page scale
Comment 1 Tien-Ren Chen 2013-01-19 19:41:03 PST 
Created attachment 183653 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-19 19:43:59 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2013-01-19 19:50:02 PST 
Comment on attachment 183653 [details]
Patch

Attachment 183653 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15970434
Comment 4 Peter Beverloo (cr-android ews) 2013-01-19 20:03:59 PST 
Comment on attachment 183653 [details]
Patch

Attachment 183653 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15972426
Comment 5 Adam Barth 2013-01-20 00:28:00 PST 
Comment on attachment 183653 [details]
Patch

Can we test this change?  Also, it looks like you're failing the Chromium EWS bots.
Comment 6 Tien-Ren Chen 2013-01-22 16:46:43 PST 
Created attachment 184077 [details]
Patch
Comment 7 Tien-Ren Chen 2013-01-22 16:50:42 PST 
Created attachment 184081 [details]
Patch
Comment 8 Tien-Ren Chen 2013-01-28 21:29:05 PST 
Created attachment 185148 [details]
Patch
Comment 9 Tien-Ren Chen 2013-01-28 21:29:45 PST 
Changes from last patch:
* Added WebFrameTest.DisambiguationPopupPageScale unit test
* Rebased
Comment 10 Adam Barth 2013-01-28 21:32:51 PST 
Comment on attachment 185148 [details]
Patch

Thanks for the test.
Comment 11 WebKit Review Bot 2013-01-28 23:30:58 PST 
Comment on attachment 185148 [details]
Patch

Clearing flags on attachment: 185148

Committed r141062: <http://trac.webkit.org/changeset/141062>
Comment 12 WebKit Review Bot 2013-01-28 23:31:03 PST 
All reviewed patches have been landed.  Closing bug.