Bug 107379

Summary: buildbot should not rely on webkitpy
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alancutter, dpranke, eric, lforschler, mithro, ossy, webkit-bug-importer, webkit.review.bot, wsiegrist
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Removes the dependency
none
Updated for ToT eric: review+

Ryosuke Niwa
Reported 2013-01-19 14:02:25 PST
It appears that the master.cfg and committer_auth.py only import webkitpy.common.net.htdigestparser and webkitpy.common.config.build from webkitpy, both of which are never used elsewhere in webkitpy. So we can just move these files into BuildSlaveSupport and remove the entire dependency.
Attachments
Removes the dependency (42.50 KB, patch)
2013-01-22 22:49 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Updated for ToT (42.75 KB, patch)
2013-01-31 19:21 PST, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-01-22 22:49:00 PST
Created attachment 184146 [details] Removes the dependency
Radar WebKit Bug Importer
Comment 2 2013-01-22 22:50:03 PST
<rdar://problem/13068009>
Eric Seidel (no email)
Comment 3 2013-01-22 22:53:47 PST
Comment on attachment 184146 [details] Removes the dependency View in context: https://bugs.webkit.org/attachment.cgi?id=184146&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:89 > +# FIXME: We should run this file as part of test-rm . > +# Unfortunately test-rm currently requires that unittests > +# be located in a directory with a valid module name. > +# 'build.webkit.org-config' is not a valid module name (due to '.' and '-') > +# so for now this is a stand-alone test harness. What is test-rm?
Ryosuke Niwa
Comment 4 2013-01-22 23:10:57 PST
(In reply to comment #3) > (From update of attachment 184146 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184146&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:89 > > +# FIXME: We should run this file as part of test-rm . > > +# Unfortunately test-rm currently requires that unittests > > +# be located in a directory with a valid module name. > > +# 'build.webkit.org-config' is not a valid module name (due to '.' and '-') > > +# so for now this is a stand-alone test harness. > > What is test-rm? I don't know. I just copy & pasted that from mastercfg_unittest.py.
Ryosuke Niwa
Comment 5 2013-01-31 19:21:38 PST
Created attachment 185917 [details] Updated for ToT
Eric Seidel (no email)
Comment 6 2013-01-31 19:47:28 PST
Comment on attachment 185917 [details] Updated for ToT LGTM.
Ryosuke Niwa
Comment 7 2013-01-31 20:03:22 PST
Committed r141530: <http://trac.webkit.org/changeset/141530>
Note You need to log in before you can comment on or make changes to this bug.