Bug 107284

Summary: [BlackBerry] Set spellchecking calculations on a timer to free up the WebKit thread
Product: WebKit Reporter: Nima Ghanavatian <nima.ghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch rwlbuis: review+

Nima Ghanavatian
Reported 2013-01-18 07:39:08 PST
SSIA
Attachments
Patch (23.74 KB, patch)
2013-01-18 08:08 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (24.22 KB, patch)
2013-01-18 08:55 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (24.16 KB, patch)
2013-01-18 09:12 PST, Nima Ghanavatian 		rwlbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2013-01-18 08:08:47 PST
Created attachment 183463 [details] Patch
Rob Buis
Comment 2 2013-01-18 08:14:23 PST
Comment on attachment 183463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183463&action=review LGTM. > Source/WebKit/blackberry/WebKitSupport/InputHandler.h:167 > + void callRequestCheckingFor(WTF::PassRefPtr<WebCore::SpellCheckRequest>); You should not need the WTF prefix. > Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp:81 > + WTF::RefPtr<WebCore::Range> rangeForSpellChecking = rangeForSpellCheckingPtr; Ditto.
Nima Ghanavatian
Comment 3 2013-01-18 08:55:47 PST
Created attachment 183470 [details] Patch
Rob Buis
Comment 4 2013-01-18 08:58:36 PST
Comment on attachment 183470 [details] Patch OK.
WebKit Review Bot
Comment 5 2013-01-18 09:03:54 PST
Comment on attachment 183470 [details] Patch Rejecting attachment 183470 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: nk #4 FAILED at 164. Hunk #5 succeeded at 204 (offset -16 lines). Hunk #6 FAILED at 268. 2 out of 6 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/InputHandler.h.rej patching file Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp patching file Source/WebKit/blackberry/WebKitSupport/SpellingHandler.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15940743
Nima Ghanavatian
Comment 6 2013-01-18 09:12:06 PST
Created attachment 183477 [details] Patch
Rob Buis
Comment 7 2013-01-18 09:15:21 PST
Comment on attachment 183477 [details] Patch Retrying.
Nima Ghanavatian
Comment 8 2013-01-18 10:02:55 PST
landed in r140170
Note You need to log in before you can comment on or make changes to this bug.