| Summary: | [BlackBerry] Set spellchecking calculations on a timer to free up the WebKit thread | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nima Ghanavatian <nima.ghanavatian> | ||||||||
| Component: | WebKit BlackBerry | Assignee: | Nima Ghanavatian <nghanavatian> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Nima Ghanavatian
2013-01-18 07:39:08 PST
Created attachment 183463 [details]
Patch
Comment on attachment 183463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183463&action=review LGTM. > Source/WebKit/blackberry/WebKitSupport/InputHandler.h:167 > + void callRequestCheckingFor(WTF::PassRefPtr<WebCore::SpellCheckRequest>); You should not need the WTF prefix. > Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp:81 > + WTF::RefPtr<WebCore::Range> rangeForSpellChecking = rangeForSpellCheckingPtr; Ditto. Created attachment 183470 [details]
Patch
Comment on attachment 183470 [details]
Patch
OK.
Comment on attachment 183470 [details] Patch Rejecting attachment 183470 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: nk #4 FAILED at 164. Hunk #5 succeeded at 204 (offset -16 lines). Hunk #6 FAILED at 268. 2 out of 6 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/InputHandler.h.rej patching file Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp patching file Source/WebKit/blackberry/WebKitSupport/SpellingHandler.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15940743 Created attachment 183477 [details]
Patch
Comment on attachment 183477 [details]
Patch
Retrying.
|