| Summary: | Consolidate and run ARIA-list-and-listitem accessibility test | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Holt <brian.holt> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, dglazkov, dmazzoni, jdiggs, rniwa, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Brian Holt
2013-01-18 07:38:41 PST
Created attachment 183472 [details]
Patch proposal
Adding people who might be interested to CC. Comment on attachment 183472 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=183472&action=review > LayoutTests/ChangeLog:10 > + therefore platform specific tests can be consolidated into a Did you mean to say "platform specific expectations"? Created attachment 183487 [details]
2nd patch proposal
Comment on attachment 183487 [details] 2nd patch proposal Attachment 183487 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15957218 New failing tests: accessibility/aria-list-and-listitem.html Comment on attachment 183487 [details] 2nd patch proposal Attachment 183487 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/15944666 New failing tests: accessibility/aria-list-and-listitem.html Comment on attachment 183487 [details] 2nd patch proposal Attachment 183487 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15946543 New failing tests: accessibility/aria-list-and-listitem.html Created attachment 183776 [details]
Made exception for Mac
Comment on attachment 183776 [details]
Made exception for Mac
what's the mac exception? i don't see anything referencing an exception with this patch
The previous patch that I proposed removed the mac-specific expectation in favour of a generic test expectation, but I was mistaken - there should be an platform specific expectation for mac (which is what I named this 3rd proposal). (In reply to comment #10) > The previous patch that I proposed removed the mac-specific expectation in favour of a generic test expectation, but I was mistaken - there should be an platform specific expectation for mac (which is what I named this 3rd proposal). your change log says "Mac exception" - i guess you meant to say "Mac expectation" (?) > your change log says "Mac exception" - i guess you meant to say "Mac expectation" (?)
I suppose I could have been clearer - what I mean is that the output is now the same on most platforms (i.e. a generic expectation) with the exception of Mac (which still requires a platform-specific expectation). Would you prefer me to update the ChangeLog?
Comment on attachment 183776 [details]
Made exception for Mac
thanks. understand now
Comment on attachment 183776 [details]
Made exception for Mac
Ready to commit?
Comment on attachment 183776 [details] Made exception for Mac Clearing flags on attachment: 183776 Committed r140343: <http://trac.webkit.org/changeset/140343> All reviewed patches have been landed. Closing bug. |