Bug 107278

Summary: Web Inspector: Native Memory Instrumentation: replace nodeName argument with className
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, benjamin, keishi, loislo, ojan.autocc, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 107303    
Bug Blocks: 107254    
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Description Ilya Tikhonovsky 2013-01-18 06:51:45 PST 
I found that in all the cases we need className when we report raw and private buffers and never need nodeName.
Comment 1 Ilya Tikhonovsky 2013-01-18 06:55:08 PST 
Created attachment 183444 [details]
Patch
Comment 2 Yury Semikhatsky 2013-01-18 07:23:37 PST 
Comment on attachment 183444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183444&action=review

> Source/WTF/wtf/MemoryInstrumentation.h:261
> +    MemoryClassInfo info(memoryObjectInfo, object, 0, sizeof(T));

How is it related to this change?

> Source/WTF/wtf/MemoryInstrumentationHashCountedSet.h:45
> +    info.addPrivateBuffer(sizeof(typename HashMapType::ValueType) * hashSet->capacity(), "ValueType[]", "data");

It seems that we can derive actual name for ValueType automatically the same way as you do for other classes in https://bugs.webkit.org/show_bug.cgi?id=107262.

> Source/WTF/wtf/MemoryInstrumentationParsedURL.h:43
> +    info.addMember(urlString->string(), "string");

This seems unrelated. You can do this as part of https://bugs.webkit.org/show_bug.cgi?id=107262 or similar bug.
Comment 3 Ilya Tikhonovsky 2013-01-18 10:28:26 PST 
Created attachment 183499 [details]
Patch
Comment 4 Ilya Tikhonovsky 2013-01-31 22:53:57 PST 
Committed r141539: <http://trac.webkit.org/changeset/141539>