| Summary: | [chromium] move speech related methods to TestRunner library | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||
| Component: | Tools / Tests | Assignee: | jochen | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dcarney, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 91308 | ||||||||
| Attachments: |
|
||||||||
Created attachment 183663 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 183663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183663&action=review > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:110 > +#if ENABLE(INPUT_SPEECH) We don't usually put ENABLE macros in public header files. The consumers of these headers on the Chromium side won't know what features are enabled. Created attachment 183678 [details]
Patch for landing
Comment on attachment 183678 [details] Patch for landing Clearing flags on attachment: 183678 Committed r140277: <http://trac.webkit.org/changeset/140277> All reviewed patches have been landed. Closing bug. |
Move void addMockSpeechInputResult(const CppArgumentList&, CppVariant*); void setMockSpeechInputDumpRect(const CppArgumentList&, CppVariant*); void addMockSpeechRecognitionResult(const CppArgumentList&, CppVariant*); void setMockSpeechRecognitionError(const CppArgumentList&, CppVariant*); void wasMockSpeechRecognitionAborted(const CppArgumentList&, CppVariant*);