Bug 107266 – [chromium] move speech related methods to TestRunner library

• Component: Tools / Tests
• Status: RESOLVED FIXED

Move

    void addMockSpeechInputResult(const CppArgumentList&, CppVariant*);
    void setMockSpeechInputDumpRect(const CppArgumentList&, CppVariant*);
    void addMockSpeechRecognitionResult(const CppArgumentList&, CppVariant*);
    void setMockSpeechRecognitionError(const CppArgumentList&, CppVariant*);
    void wasMockSpeechRecognitionAborted(const CppArgumentList&, CppVariant*);

Created attachment 183663 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 183663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183663&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:110
> +#if ENABLE(INPUT_SPEECH)

We don't usually put ENABLE macros in public header files.  The consumers of these headers on the Chromium side won't know what features are enabled.

Created attachment 183678 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 183678 [details]
Patch for landing

Clearing flags on attachment: 183678

Committed r140277: <http://trac.webkit.org/changeset/140277>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.