Bug 107245

Summary: [V8] Remove custom V8ScriptProfileNodeCustom::toV8()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gyuyoung.kim, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2013-01-18 02:08:39 PST
V8ScriptProfileNodeCustom::toV8() needs not to be custom. Furthermore, the current custom toV8() is wrong in that it doesn't use a creationContext and it doesn't set a wrapper class id. This is one of steps to avoiding ASSERT()s that will be added in https://bugs.webkit.org/show_bug.cgi?id=107137 .
Attachments
Patch (5.74 KB, patch)
2013-01-18 02:10 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-01-18 02:10:16 PST
Created attachment 183409 [details] Patch
WebKit Review Bot
Comment 2 2013-01-18 11:15:59 PST
Comment on attachment 183409 [details] Patch Clearing flags on attachment: 183409 Committed r140185: <http://trac.webkit.org/changeset/140185>
WebKit Review Bot
Comment 3 2013-01-18 11:16:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.