Bug 107222

Summary: [Shadow DOM] Specifying scrollbar style of an element having RenderLayer in ShadowDOM does not work.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: CSSAssignee: Web Components Team <webcomponents-bugzilla>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dglazkov, eric, ojan.autocc, peter+ews, rniwa, simon.fraser, webcomponents-bugzilla, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91821    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2013-01-17 21:47:14 PST
scrollbar style for host is applied instead. The reason is RenderLayer uses shadowAncestorNode() anytime. Maybe we have to check ShadowRoot->type()?
Attachments
Patch (7.22 KB, patch)
2013-01-17 22:26 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (6.54 KB, patch)
2013-01-17 23:16 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.27 KB, patch)
2013-01-20 17:54 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2013-01-17 22:26:12 PST
Created attachment 183377 [details] Patch
WebKit Review Bot
Comment 2 2013-01-17 22:29:10 PST
Comment on attachment 183377 [details] Patch Attachment 183377 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15939473
Build Bot
Comment 3 2013-01-17 22:30:54 PST
Comment on attachment 183377 [details] Patch Attachment 183377 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/15947283
Build Bot
Comment 4 2013-01-17 22:31:32 PST
Comment on attachment 183377 [details] Patch Attachment 183377 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15925965
Peter Beverloo (cr-android ews)
Comment 5 2013-01-17 22:33:59 PST
Comment on attachment 183377 [details] Patch Attachment 183377 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15955051
Early Warning System Bot
Comment 6 2013-01-17 22:43:04 PST
Comment on attachment 183377 [details] Patch Attachment 183377 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15940511
Early Warning System Bot
Comment 7 2013-01-17 22:49:43 PST
Comment on attachment 183377 [details] Patch Attachment 183377 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15937556
Shinya Kawanaka
Comment 8 2013-01-17 23:15:19 PST
Oops I forgot to remove debug code...
Shinya Kawanaka
Comment 9 2013-01-17 23:16:01 PST
Created attachment 183384 [details] Patch
Simon Fraser (smfr)
Comment 10 2013-01-18 08:53:29 PST
Comment on attachment 183384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183384&action=review > Source/WebCore/rendering/RenderLayer.cpp:2698 > +static inline RenderObject* actualRendererForScrollbar(RenderObject* renderer) I think you could just call this rendererForScrollbar()
Shinya Kawanaka
Comment 11 2013-01-20 17:49:36 PST
(In reply to comment #10) > (From update of attachment 183384 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183384&action=review > > > Source/WebCore/rendering/RenderLayer.cpp:2698 > > +static inline RenderObject* actualRendererForScrollbar(RenderObject* renderer) > > I think you could just call this rendererForScrollbar() Thanks. I'll update the patch and land it.
Shinya Kawanaka
Comment 12 2013-01-20 17:54:23 PST
Created attachment 183693 [details] Patch for landing
WebKit Review Bot
Comment 13 2013-01-20 18:26:15 PST
Comment on attachment 183693 [details] Patch for landing Clearing flags on attachment: 183693 Committed r140287: <http://trac.webkit.org/changeset/140287>
WebKit Review Bot
Comment 14 2013-01-20 18:26:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.