Summary: | Make it possible for the root background to be painted into its own GraphicsLayer | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dino, eric, hclam, jonlee, ojan.autocc, simon.fraser, webkit-ews, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2013-01-17 14:08:22 PST
Created attachment 183278 [details]
Patch
Attachment 183278 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5]
Total errors found: 1 in 32 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 183278 [details] Patch Attachment 183278 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15945123 Comment on attachment 183278 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183278&action=review r=me, fix the style issues. > Source/WebCore/rendering/RenderObject.h:547 > + bool hasEntirelyFixedBackground() const; I'd just inline this like the method above it. Created attachment 183295 [details]
Fix build errors
Comment on attachment 183295 [details]
Fix build errors
Moving hyatt's r+ forward
Attachment 183295 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5]
Total errors found: 1 in 32 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The crash happens on one of our bots: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/4237/steps/webkit_tests/logs/stdio Please look for svg/wicd/test-scalable-background-image2.xhtml in the log. |