Bug 107177

Summary: Make it possible for the root background to be painted into its own GraphicsLayer
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric, hclam, jonlee, ojan.autocc, simon.fraser, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix build errors simon.fraser: review+

Simon Fraser (smfr)
Reported 2013-01-17 14:08:22 PST
We plan to paint the root background into its own GraphicsLayer, which we can leave unscrolled as the page scrolls, to avoid painting.
Attachments
Patch (1.23 MB, patch)
2013-01-17 14:29 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Fix build errors (1.23 MB, patch)
2013-01-17 15:17 PST, Simon Fraser (smfr) 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-01-17 14:29:25 PST
Created attachment 183278 [details] Patch
WebKit Review Bot
Comment 2 2013-01-17 14:32:47 PST
Attachment 183278 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2013-01-17 14:37:46 PST
Comment on attachment 183278 [details] Patch Attachment 183278 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15945123
Dave Hyatt
Comment 4 2013-01-17 14:43:25 PST
Comment on attachment 183278 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183278&action=review r=me, fix the style issues. > Source/WebCore/rendering/RenderObject.h:547 > + bool hasEntirelyFixedBackground() const; I'd just inline this like the method above it.
Simon Fraser (smfr)
Comment 5 2013-01-17 15:17:16 PST
Created attachment 183295 [details] Fix build errors
Simon Fraser (smfr)
Comment 6 2013-01-17 15:17:50 PST
Comment on attachment 183295 [details] Fix build errors Moving hyatt's r+ forward
WebKit Review Bot
Comment 7 2013-01-17 15:21:12 PST
Attachment 183295 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 8 2013-01-17 16:12:56 PST
http://trac.webkit.org/changeset/140068
Hin-Chung Lam
Comment 9 2013-01-17 16:50:06 PST
The crash happens on one of our bots: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/4237/steps/webkit_tests/logs/stdio
Hin-Chung Lam
Comment 10 2013-01-17 16:50:44 PST
Please look for svg/wicd/test-scalable-background-image2.xhtml in the log.
Note You need to log in before you can comment on or make changes to this bug.