| Summary: | Stop the background parser when canceling parsing to avoid crashing on many layout tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, tonyg, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 106127 | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Seidel (no email)
2013-01-17 12:32:19 PST
Created attachment 183246 [details]
Patch
Comment on attachment 183246 [details] Patch Rejecting attachment 183246 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: o-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -c ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp -o obj/Source/WebCore/html/parser/webcore_html.HTMLDocumentParser.o ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp: In member function 'virtual void WebCore::HTMLDocumentParser::stopParsing()': ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:134: error: 'stopBackgroundParser' was not declared in this scope ninja: build stopped: subcommand failed. Full output: http://queues.webkit.org/results/15943107 I guess the rest hasnt' been upstreamed yet? Oh, this needs enable wraps. Created attachment 183251 [details]
Patch for landing
Comment on attachment 183251 [details] Patch for landing Clearing flags on attachment: 183251 Committed r140050: <http://trac.webkit.org/changeset/140050> All reviewed patches have been landed. Closing bug. |