Bug 107151

Summary: MathML padding overrides only need to be on RenderMathMLRoot
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: davidc, dbarton, eae, eric, fred.wang, jchaffraix, leviw, ojan.autocc, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ojan Vafai
Reported 2013-01-17 12:01:47 PST
MathML padding overrides only need to be on RenderMathMLRoot
Attachments
Patch (11.55 KB, patch)
2013-01-17 12:03 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2013-01-17 12:03:08 PST
Created attachment 183238 [details] Patch
Dave Barton
Comment 2 2013-01-17 12:53:24 PST
Actually this whole mechanism (intrinsic padding for MathML) could be removed now, using flexbox's order property instead of absolute positioning, to get <mroot>'s 2nd child (the index) to be placed before the first child (the base, i.e. radicand). (Note this technique also fixes a major limitation of http://www.w3.org/TR/mathml-for-css/#d2e165 for other browser engines.) I recommend this - I know the guys who implemented flexbox in webkit and they're really smart. :)
WebKit Review Bot
Comment 3 2013-01-17 12:57:24 PST
Comment on attachment 183238 [details] Patch Clearing flags on attachment: 183238 Committed r140032: <http://trac.webkit.org/changeset/140032>
WebKit Review Bot
Comment 4 2013-01-17 12:57:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.