Summary: | Wire BackgroundHTMLParser to HTMLDocumentParser | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||||
Component: | WebCore Misc. | Assignee: | Tony Gentilcore <tonyg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ojan.autocc, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 106127 | ||||||||
Attachments: |
|
Description
Tony Gentilcore
2013-01-17 10:12:12 PST
Created attachment 183211 [details]
Patch
Comment on attachment 183211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183211&action=review > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:182 > - parser->didReceiveTokensFromBackgroundParser(delivery->tokens); > + parser->feedTokens(delivery->tokens); Can we keep the didReceiveTokensFromBackgroundParser name? It's much more descriptive than "feedTokens". > Source/WebCore/html/parser/HTMLDocumentParser.h:44 > +class BackgroundHTMLParser; I would probably put this forward declaration inside the ifdef. Created attachment 183213 [details]
Patch for landing
(In reply to comment #2) > (From update of attachment 183211 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183211&action=review > > > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:182 > > - parser->didReceiveTokensFromBackgroundParser(delivery->tokens); > > + parser->feedTokens(delivery->tokens); > > Can we keep the didReceiveTokensFromBackgroundParser name? It's much more descriptive than "feedTokens". Done. > > > Source/WebCore/html/parser/HTMLDocumentParser.h:44 > > +class BackgroundHTMLParser; > > I would probably put this forward declaration inside the ifdef. Actually it wasn't necessary at all. I removed it. Comment on attachment 183213 [details] Patch for landing Clearing flags on attachment: 183213 Committed r140019: <http://trac.webkit.org/changeset/140019> All reviewed patches have been landed. Closing bug. |