Bug 107140 - Wire BackgroundHTMLParser to HTMLDocumentParser
Summary: Wire BackgroundHTMLParser to HTMLDocumentParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-01-17 10:12 PST by Tony Gentilcore
Modified: 2013-01-17 11:53 PST (History)
3 users (show)

See Also:


Attachments
Patch (12.85 KB, patch)
2013-01-17 10:46 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch for landing (11.49 KB, patch)
2013-01-17 10:58 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2013-01-17 10:12:12 PST
Wire BackgroundHTMLParser to HTMLDocumentParser
Comment 1 Tony Gentilcore 2013-01-17 10:46:58 PST
Created attachment 183211 [details]
Patch
Comment 2 Adam Barth 2013-01-17 10:53:43 PST
Comment on attachment 183211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183211&action=review

> Source/WebCore/html/parser/BackgroundHTMLParser.cpp:182
> -            parser->didReceiveTokensFromBackgroundParser(delivery->tokens);
> +            parser->feedTokens(delivery->tokens);

Can we keep the didReceiveTokensFromBackgroundParser name?  It's much more descriptive than "feedTokens".

> Source/WebCore/html/parser/HTMLDocumentParser.h:44
> +class BackgroundHTMLParser;

I would probably put this forward declaration inside the ifdef.
Comment 3 Tony Gentilcore 2013-01-17 10:58:41 PST
Created attachment 183213 [details]
Patch for landing
Comment 4 Tony Gentilcore 2013-01-17 11:00:00 PST
(In reply to comment #2)
> (From update of attachment 183211 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183211&action=review
> 
> > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:182
> > -            parser->didReceiveTokensFromBackgroundParser(delivery->tokens);
> > +            parser->feedTokens(delivery->tokens);
> 
> Can we keep the didReceiveTokensFromBackgroundParser name?  It's much more descriptive than "feedTokens".

Done.

> 
> > Source/WebCore/html/parser/HTMLDocumentParser.h:44
> > +class BackgroundHTMLParser;
> 
> I would probably put this forward declaration inside the ifdef.

Actually it wasn't necessary at all. I removed it.
Comment 5 WebKit Review Bot 2013-01-17 11:53:33 PST
Comment on attachment 183213 [details]
Patch for landing

Clearing flags on attachment: 183213

Committed r140019: <http://trac.webkit.org/changeset/140019>
Comment 6 WebKit Review Bot 2013-01-17 11:53:36 PST
All reviewed patches have been landed.  Closing bug.