| Summary: | Make renderer construction take Element where possible | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, dbarton, dglazkov, d-r, eric.carlson, eric, feature-media-reviews, fmalita, hclam, hyatt, kling, mifenton, ojan.autocc, pdr, peter+ews, schenney, simon.fraser, tkent, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 107176 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2013-01-17 10:05:32 PST
Created attachment 183217 [details]
patch
Comment on attachment 183217 [details]
patch
r=me
Comment on attachment 183217 [details] patch Attachment 183217 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15925698 This patch seems to failure a number of tests on Lion and Mountain Lion: http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/8275 http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/5804 EWS also says these tests are failing on Mac: Regressions: Unexpected text-only failures (29) accessibility/render-counter-text.html [ Failure ] editing/selection/5240265.html [ Failure ] editing/selection/css-pseudo-element.html [ Failure ] editing/selection/focus-crash.html [ Failure ] editing/selection/hit-test-anonymous.html [ Failure ] editing/selection/undo-crash.html [ Failure ] fast/css-generated-content/hover-inline.html [ Failure ] fast/dom/Node/mutation-blur.html [ Failure ] fast/events/domactivate-sets-underlying-click-event-as-handled.html [ Failure ] fast/events/popup-allowed-from-gesture-initiated-form-submit.html [ Failure ] fast/events/popup-blocked-from-untrusted-mouse-click.html [ Failure ] fast/forms/multiple-form-submission-protection-mouse.html [ Failure ] fast/forms/range/slider-delete-while-dragging-thumb.html [ Failure ] fast/forms/search-delete-while-cancel-button-clicked.html [ Failure ] fast/forms/submit-to-blank-multiple-times.html [ Failure ] fast/history/form-submit-in-frame-via-onclick.html [ Failure ] fast/history/form-submit-in-frame.html [ Failure ] fast/history/gesture-before-onload-form-submit.html [ Failure ] fast/history/history_reload.html [ Failure ] fast/images/animated-gif-restored-from-bfcache.html [ Failure ] fast/loader/javascript-url-in-object.html [ Failure ] http/tests/inspector/console-resource-errors.html [ Failure ] http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html [ Failure ] inspector/styles/styles-source-offsets.html [ Failure ] media/audio-delete-while-slider-thumb-clicked.html [ Failure ] media/media-fullscreen-inline.html [ Failure ] platform/mac/accessibility/css-content-attribute.html [ Failure ] svg/batik/text/smallFonts.svg [ Failure ] svg/dom/SVGScriptElement/script-load-and-error-events.svg [ Failure ] Re-opened since this is blocked by bug 107176 Created attachment 183532 [details]
patch2
For EWS with a RenderText fix
Attachment 183532 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderText.cpp:139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 99 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 183532 [details] patch2 Attachment 183532 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15940845 Comment on attachment 183532 [details] patch2 Attachment 183532 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15939816 http://trac.webkit.org/changeset/140244 (with chrome test build fix) |