Bug 107117

Summary: PDFPlugin: Build PDFPlugin everywhere, enable at runtime
Product: WebKit Reporter: Tim Horton <thorton>
Component: PDFAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch ap: review+

Tim Horton
Reported 2013-01-17 05:03:20 PST
Since PDFLayerController SPI is all forward-declared, this should build anywhere, and can be enabled/disabled at runtime.
Attachments
patch (6.45 KB, patch)
2013-01-17 05:05 PST, Tim Horton 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-01-17 05:05:29 PST
Created attachment 183168 [details] patch
Alexey Proskuryakov
Comment 2 2013-01-17 08:48:26 PST
Comment on attachment 183168 [details] patch r=me on the assumption that there is enough runtime detection in place already to not break PDFs in nightlies.
Tim Horton
Comment 3 2013-01-22 00:30:32 PST
(In reply to comment #2) > (From update of attachment 183168 [details]) > r=me on the assumption that there is enough runtime detection in place already to not break PDFs in nightlies. Not... exactly. It's an off-by-default setting. So there's no runtime detection; things will break if you flip the setting, but that's your own fault :D It won't break the nightlies. I'm going to land this and file another bug about making the setting's default value depend on the existence of PDFLayerController.
Tim Horton
Comment 4 2013-01-22 00:40:04 PST
http://trac.webkit.org/changeset/140394
Tim Horton
Comment 5 2013-01-22 00:41:25 PST
(In reply to comment #3) > I'm going to land this and file another bug about making the setting's default value depend on the existence of PDFLayerController. --> https://bugs.webkit.org/show_bug.cgi?id=107514
Note You need to log in before you can comment on or make changes to this bug.