Summary: | [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xiaobo Wang <xiaobwang> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Other | ||||||
Attachments: |
|
Description
Xiaobo Wang
2013-01-17 01:56:49 PST
Created attachment 183152 [details]
patch
Comment on attachment 183152 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=183152&action=review > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:176 > +} I am not sure if we need this complexity for two string comparisons? Or are you expecting more entries in the Vector? Comment on attachment 183152 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=183152&action=review >> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:176 >> +} > > I am not sure if we need this complexity for two string comparisons? Or are you expecting more entries in the Vector? Yes, I'm expecting more protocols to be added, such as https://. If we only consider these two, I can update the patch to make it simple. Comment on attachment 183152 [details]
patch
Ok.
Comment on attachment 183152 [details] patch Clearing flags on attachment: 183152 Committed r140100: <http://trac.webkit.org/changeset/140100> All reviewed patches have been landed. Closing bug. |