Bug 107107

Summary: [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
Product: WebKit Reporter: Xiaobo Wang <xiaobwang>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
patch none

Xiaobo Wang
Reported 2013-01-17 01:56:49 PST
Currently we only accept DRT test file (relative to webkit/LayoutTests). Developers have an requirement to dump render tree from command line for http:// URL, as well as relative/absolute file path.
Attachments
patch (2.93 KB, patch)
2013-01-17 02:06 PST, Xiaobo Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xiaobo Wang
Comment 1 2013-01-17 02:06:03 PST
Created attachment 183152 [details] patch
Rob Buis
Comment 2 2013-01-17 11:06:58 PST
Comment on attachment 183152 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=183152&action=review > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:176 > +} I am not sure if we need this complexity for two string comparisons? Or are you expecting more entries in the Vector?
Xiaobo Wang
Comment 3 2013-01-17 18:01:54 PST
Comment on attachment 183152 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=183152&action=review >> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:176 >> +} > > I am not sure if we need this complexity for two string comparisons? Or are you expecting more entries in the Vector? Yes, I'm expecting more protocols to be added, such as https://. If we only consider these two, I can update the patch to make it simple.
Rob Buis
Comment 4 2013-01-17 18:21:07 PST
Comment on attachment 183152 [details] patch Ok.
WebKit Review Bot
Comment 5 2013-01-17 20:43:03 PST
Comment on attachment 183152 [details] patch Clearing flags on attachment: 183152 Committed r140100: <http://trac.webkit.org/changeset/140100>
WebKit Review Bot
Comment 6 2013-01-17 20:43:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.