Summary: | Add a USE() macro for content filtering code | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, ddkilzer, japhet, ojan.autocc, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andy Estes
2013-01-16 23:22:31 PST
Created attachment 183128 [details]
Patch
Comment on attachment 183128 [details]
Patch
Mark Rowe suggested that USE() is more appropriate for this, and on second thought, I agree.
Created attachment 183134 [details]
Patch
Comment on attachment 183134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183134&action=review > Source/WebCore/WebCore.exp.in:2155 > #if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 > _wkExecutableWasLinkedOnOrBeforeLion > +#endif Nit: I would just move this down to the other "#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080" block below. Committed r140366: <http://trac.webkit.org/changeset/140366> (In reply to comment #5) > Committed r140366: <http://trac.webkit.org/changeset/140366> Follow-up build fix in r140988: <http://trac.webkit.org/changeset/140988> |