Bug 107098

Summary: Add a USE() macro for content filtering code
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, ddkilzer, japhet, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mrowe: review+

Andy Estes
Reported 2013-01-16 23:22:31 PST
Add an ENABLE() macro for content filtering code
Attachments
Patch (36.51 KB, patch)
2013-01-16 23:35 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (12.95 KB, patch)
2013-01-17 00:36 PST, Andy Estes 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2013-01-16 23:35:11 PST
Created attachment 183128 [details] Patch
mitz
Comment 2 2013-01-16 23:47:03 PST
Comment on attachment 183128 [details] Patch Mark Rowe suggested that USE() is more appropriate for this, and on second thought, I agree.
Andy Estes
Comment 3 2013-01-17 00:36:52 PST
Created attachment 183134 [details] Patch
David Kilzer (:ddkilzer)
Comment 4 2013-01-17 08:33:22 PST
Comment on attachment 183134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183134&action=review > Source/WebCore/WebCore.exp.in:2155 > #if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 > _wkExecutableWasLinkedOnOrBeforeLion > +#endif Nit: I would just move this down to the other "#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080" block below.
Andy Estes
Comment 5 2013-01-21 14:46:25 PST
Committed r140366: <http://trac.webkit.org/changeset/140366>
David Kilzer (:ddkilzer)
Comment 6 2013-01-28 11:58:52 PST
(In reply to comment #5) > Committed r140366: <http://trac.webkit.org/changeset/140366> Follow-up build fix in r140988: <http://trac.webkit.org/changeset/140988>
Note You need to log in before you can comment on or make changes to this bug.