Bug 107091

Summary: Use xcrun to find path to make for Mac port
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, dfarler, dpranke, eric, mitz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 mitz: review+

Description David Kilzer (:ddkilzer) 2013-01-16 21:10:21 PST
Created attachment 183113 [details]
Patch

<http://webkit.org/b/000000>

Reviewed by NOBODY (OOPS!).

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._build_java_test_support): Call self.make_command().
(MacPort.make_command): Add.  Tries to find a path for the make
command using xcrun.  Falls back to returning '/usr/bin/make'.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._build_java_test_support): Call self.make_command().
(MacPort.make_command): Add.  Call xcrun_find().
(MacPort.nm_command): Use self.xcrun_find().
(MacPort.xcrun_find): Add.  Extract from nm_command().
---
 2 files changed, 29 insertions(+), 5 deletions(-)
Comment 1 David Kilzer (:ddkilzer) 2013-01-16 21:12:41 PST
Created attachment 183115 [details]
Patch v2
Comment 2 David Kilzer (:ddkilzer) 2013-01-16 21:22:41 PST
(In reply to comment #1)
> Created an attachment (id=183115) [details]
> Patch v2

Heh, python needs 'return' statements to actually return values.  Will land this manually with those added.
Comment 3 David Kilzer (:ddkilzer) 2013-01-16 21:33:23 PST
Committed r139965: <http://trac.webkit.org/changeset/139965>
Comment 4 Eric Seidel (no email) 2013-01-16 22:24:17 PST
Comment on attachment 183115 [details]
Patch v2

Fantastic.