Bug 107084

Summary: Coordinated Graphics: Remove redundant behaviors in LayerTreeRenderer.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103854    
Attachments:
Description Flags
Patch none

Description Dongseong Hwang 2013-01-16 19:06:34 PST
There are two changes.
1. It is redundant to call GraphicsLayer::removeFromParent() or GraphicsLayer::removeAllChildren() before deleting GraphicsLayer, because the destructor of GraphicsLayerTextureMapper does those.
2. LayerTreeRenderer::setRootLayerID() does not need to remove all children of rootLayer because this method can be called only once.
Comment 1 Dongseong Hwang 2013-01-16 19:08:55 PST
Created attachment 183096 [details]
Patch
Comment 2 Noam Rosenthal 2013-01-16 23:41:21 PST
Comment on attachment 183096 [details]
Patch

I would consider this trivial; Allowing myself to r+.
Comment 3 WebKit Review Bot 2013-01-17 14:56:33 PST
Comment on attachment 183096 [details]
Patch

Clearing flags on attachment: 183096

Committed r140053: <http://trac.webkit.org/changeset/140053>
Comment 4 WebKit Review Bot 2013-01-17 14:56:37 PST
All reviewed patches have been landed.  Closing bug.