Summary: | Introduce BackgroundHTMLParser for parsing HTML on a background thread | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, gyuyoung.kim, ojan.autocc, rakuco, tonyg, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 106127 | ||||||
Attachments: |
|
Description
Adam Barth
2013-01-16 18:43:07 PST
Created attachment 183091 [details]
Patch
Comment on attachment 183091 [details]
Patch
This is very primitive. But looks OK. I'm not sure I'm your ideal reviewer having written much of this, but that's true of tony too.
Comment on attachment 183091 [details] Patch Clearing flags on attachment: 183091 Committed r139950: <http://trac.webkit.org/changeset/139950> All reviewed patches have been landed. Closing bug. Comment on attachment 183091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183091&action=review > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:106 > + DEFINE_STATIC_LOCAL(AtomicString, iframeTag, ("iframe", AtomicString::ConstructFromLiteral)); Is it worth adding a FIXME about our plan for AtomicStrings? > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:164 > +class TokenDelivery { Mark this noncopyable? > Source/WebCore/html/parser/BackgroundHTMLParser.cpp:175 > + delete delivery; Is there anything we can do better than a naked delete? Sorry, this patch already landed. I'm posting a followup patch now. Followup is in bug 107086 |