| Summary: | Fix mac build system warnings introduced by r139866 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pablo Flouret <pf> | ||||||
| Component: | WebCore Misc. | Assignee: | Pablo Flouret <pf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | allan.jensen, benjamin, simon.fraser, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 183049 [details]
Patch
Comment on attachment 183049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183049&action=review > Source/WebCore/WebCore.exp.in:1580 > .objc_class_name_DOMCSSStyleSheet > -.objc_class_name_DOMCSSSupportsRule > .objc_class_name_DOMCSSUnknownRule > .objc_class_name_DOMCSSValue This is incorrect. I landed something for this: http://trac.webkit.org/changeset/139933 > Source/WebCore/WebCore.xcodeproj/project.pbxproj:26129 > + FC54D05716A7673100575E4D /* CSSSupportsRule.h in Headers */, > + FC54D05816A7676E00575E4D /* JSCSSSupportsRule.h in Headers */, This build section should be sorted alphabetically. Created attachment 183063 [details]
Patch
Comment on attachment 183063 [details]
Patch
I am no expert at Xcode project files, but that looks reasonable.
Thanks for fixing the warnings.
Comment on attachment 183063 [details] Patch Clearing flags on attachment: 183063 Committed r139941: <http://trac.webkit.org/changeset/139941> All reviewed patches have been landed. Closing bug. |
warning: no rule to process file '$(PROJECT_DIR)/css/CSSSupportsRule.h' of type sourcecode.c.h for architecture x86_64 warning: no rule to process file '$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSCSSSupportsRule.h' of type sourcecode.c.h for architecture x86_64 ld: warning: ignoring undefined symbol .objc_class_name_DOMCSSSupportsRule from -exported_symbols_list {JS,}CSSSupportsRule.h somehow ended up marked as sources in the XCode project. And explicitely declaring the DOMCSSSupportsRule symbol is apparently not needed...