Summary: | [CSS Grid Layout] infinity should be defined as a negative value | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||||
Component: | Layout and Rendering | Assignee: | Sergio Villar Senin <svillar> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | buildbot, commit-queue, donggwan.kim, esprehn+autocc, glenn, kling, kondapallykalyan, macpherson, menard, ojan, rniwa, svillar, tony, xan.lopez | ||||||
Priority: | P3 | Keywords: | BlinkMergeCandidate | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 60731 | ||||||||
Attachments: |
|
Description
Julien Chaffraix
2013-01-16 15:11:47 PST
The fix is supereasy but I'm setting the BlinkMergeCandidate keyword because it'd be interesting to share the same layout test code. This is the relevant commit in Blink: [CSS Grid Layout] infinity should be defined as a negative value This change makes us reject negative lengths at parse time, which matches the updated specification, so that we can now safely assume that when we resolve the length, it is not to a negative value. BUG=234209 TESTS=fast/css-grid-layout/grid-columns-rows-get-set.html fast/css-grid-layout/grid-columns-rows-get-set-multiple.html Review URL: https://chromiumcodereview.appspot.com/19668006 Created attachment 208201 [details]
Patch
Comment on attachment 208201 [details] Patch Attachment 208201 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1350262 New failing tests: webaudio/delaynode-max-default-delay.html Created attachment 208214 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
(In reply to comment #3) > (From update of attachment 208201 [details]) > Attachment 208201 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/1350262 > > New failing tests: > webaudio/delaynode-max-default-delay.html Totally unrelated to the patch. Committed r154730: <http://trac.webkit.org/changeset/154730> |