Bug 107053

Summary:

[CSS Grid Layout] infinity should be defined as a negative value

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Layout and Rendering

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

buildbot, commit-queue, donggwan.kim, esprehn+autocc, glenn, kling, kondapallykalyan, macpherson, menard, ojan, rniwa, svillar, tony, xan.lopez

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

60731

Attachments:

Description	Flags
Patch	kling: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none

Julien Chaffraix

Reported 2013-01-16 15:11:47 PST

Filed http://lists.w3.org/Archives/Public/www-style/2013Jan/0216.html as a specification bug. If the proposal is accepted, we could change the code from bug 106474 to use a negative value for infinity (-1 for example) and have some getters / setters that hide this information from the rest of the code. This would avoid the clash with a possible return value from computeUsedBreadthOfSpecifiedLength. Considering that it's a corner case, it's a low priority but nice to fix.

Attachments
Patch (9.69 KB, patch) 2013-08-06 10:39 PDT, Sergio Villar Senin	kling: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (497.22 KB, application/zip) 2013-08-06 13:36 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Sergio Villar Senin

Comment 1 2013-08-06 08:50:08 PDT

The fix is supereasy but I'm setting the BlinkMergeCandidate keyword because it'd be interesting to share the same layout test code. This is the relevant commit in Blink: [CSS Grid Layout] infinity should be defined as a negative value This change makes us reject negative lengths at parse time, which matches the updated specification, so that we can now safely assume that when we resolve the length, it is not to a negative value. BUG=234209 TESTS=fast/css-grid-layout/grid-columns-rows-get-set.html fast/css-grid-layout/grid-columns-rows-get-set-multiple.html Review URL: https://chromiumcodereview.appspot.com/19668006

Sergio Villar Senin

Comment 2 2013-08-06 10:39:47 PDT

Created attachment 208201 [details] Patch

Build Bot

Comment 3 2013-08-06 13:36:45 PDT

Comment on attachment 208201 [details] Patch Attachment 208201 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1350262 New failing tests: webaudio/delaynode-max-default-delay.html

Build Bot

Comment 4 2013-08-06 13:36:47 PDT

Created attachment 208214 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4

Sergio Villar Senin

Comment 5 2013-08-07 07:36:40 PDT

(In reply to comment #3) > (From update of attachment 208201 [details]) > Attachment 208201 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/1350262 > > New failing tests: > webaudio/delaynode-max-default-delay.html Totally unrelated to the patch.

Sergio Villar Senin

Comment 6 2013-08-28 02:58:02 PDT

Committed r154730: <http://trac.webkit.org/changeset/154730>

Note You need to log in before you can comment on or make changes to this bug.