Summary: | Get WinLauncher to compile in VS2010 (32 bit) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||
Component: | Platform | Assignee: | Roger Fong <roger_fong> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, jonlee, roger_fong, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Bug Depends on: | 106989 | ||||||
Bug Blocks: | 106949 | ||||||
Attachments: |
|
Description
Roger Fong
2013-01-16 11:08:50 PST
Created attachment 186915 [details]
WinLauncher patch
Property sheets, projects, resources
Comment on attachment 186915 [details] WinLauncher patch View in context: https://bugs.webkit.org/attachment.cgi?id=186915&action=review Looks good. Do you think we could change the project names as I mentioned? > WinLauncher/WinLauncher.vcxproj/WinLauncherLauncher.vcxproj:15 > + <RootNamespace>WinLauncherLauncher</RootNamespace> One thing I hate about this is that the executable is "WinLauncher.exe", but the project is "WinLauncherLauncher", so you can't set this as a target and debug directly. I wonder if "WinLauncher" could become "WinLauncherLib", and "WinLauncherLauncher" could just be "WinLauncher"? Committed: http://trac.webkit.org/changeset/142059 Will add projects to the opensource solution in another patch along with some other various solution wide touchups. |