Bug 107037

Summary: Get WinLauncher to compile in VS2010 (32 bit)
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: PlatformAssignee: Roger Fong <roger_fong>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jonlee, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on: 106989    
Bug Blocks: 106949    
Attachments:
Description Flags
WinLauncher patch bfulgham: review+, bfulgham: commit-queue-

Roger Fong
Reported 2013-01-16 11:08:50 PST
This includes WinLauncher, and WinLauncherLauncher
Attachments
WinLauncher patch (20.00 KB, patch)
2013-02-06 13:54 PST, Roger Fong 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-01-16 11:09:27 PST
<rdar://problem/13025771>
Roger Fong
Comment 2 2013-02-06 13:54:18 PST
Created attachment 186915 [details] WinLauncher patch Property sheets, projects, resources
Brent Fulgham
Comment 3 2013-02-06 15:44:37 PST
Comment on attachment 186915 [details] WinLauncher patch View in context: https://bugs.webkit.org/attachment.cgi?id=186915&action=review Looks good. Do you think we could change the project names as I mentioned? > WinLauncher/WinLauncher.vcxproj/WinLauncherLauncher.vcxproj:15 > + <RootNamespace>WinLauncherLauncher</RootNamespace> One thing I hate about this is that the executable is "WinLauncher.exe", but the project is "WinLauncherLauncher", so you can't set this as a target and debug directly. I wonder if "WinLauncher" could become "WinLauncherLib", and "WinLauncherLauncher" could just be "WinLauncher"?
Roger Fong
Comment 4 2013-02-06 17:55:07 PST
Committed: http://trac.webkit.org/changeset/142059 Will add projects to the opensource solution in another patch along with some other various solution wide touchups.
Note You need to log in before you can comment on or make changes to this bug.