Bug 106998

Summary: Web Inspector: array grouping does not work for float number keys
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 106891    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Andrey Adaikin 2013-01-16 03:01:22 PST
This is a follow-up to the https://bugs.webkit.org/show_bug.cgi?id=106891 fix, which was not quite correct.

Now we do the array index check according to the ECMAScript 5, section 15.4:
"A property name P (in the form of a String value) is an array index if and only if ToString(ToUint32(P)) is equal to P and ToUint32(P) is not equal to 2^32-1."

Patch to follow.
Comment 1 Andrey Adaikin 2013-01-16 03:03:28 PST
Created attachment 182949 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-16 08:57:42 PST
Comment on attachment 182949 [details]
Patch

Clearing flags on attachment: 182949

Committed r139887: <http://trac.webkit.org/changeset/139887>
Comment 3 WebKit Review Bot 2013-01-16 08:57:45 PST
All reviewed patches have been landed.  Closing bug.