Bug 106980

Summary: Allow PaintInfo to carry all PaintBehavior flags
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, dino, d-r, eric, fmalita, ojan.autocc, pdr, rniwa, schenney, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+
Patch bdakin: review+, buildbot: commit-queue-

Simon Fraser (smfr)
Reported 2013-01-15 21:24:40 PST
Allow PaintInfo to carry all PaintBehavior flags
Attachments
Patch (12.87 KB, patch)
2013-01-15 21:30 PST, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2013-01-16 13:44 PST, Simon Fraser (smfr) 		bdakin: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-01-15 21:30:08 PST
Created attachment 182917 [details] Patch
WebKit Review Bot
Comment 2 2013-01-15 21:32:14 PST
Attachment 182917 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/PaintInfo.h:56: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2013-01-16 12:02:35 PST
http://trac.webkit.org/changeset/139908
Simon Fraser (smfr)
Comment 4 2013-01-16 13:36:18 PST
I missed one.
Simon Fraser (smfr)
Comment 5 2013-01-16 13:44:40 PST
Created attachment 183031 [details] Patch
Build Bot
Comment 6 2013-01-16 15:54:45 PST
Comment on attachment 183031 [details] Patch Attachment 183031 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15905628 New failing tests: svg/as-image/img-relative-height.html
Simon Fraser (smfr)
Comment 7 2013-01-17 16:13:26 PST
http://trac.webkit.org/changeset/140066
Note You need to log in before you can comment on or make changes to this bug.