Bug 106969

Summary: [EFL] Move 'DefaultTheme' folder to WebCore/platform/efl
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, eric.carlson, feature-media-reviews, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Gyuyoung Kim
Reported 2013-01-15 18:33:03 PST
DefaultTheme is used by both EFL WK1 and WK2 ports. So, WebCore/platform/efl is appropriate place for it.
Attachments
Patch (454.50 KB, patch)
2013-01-15 18:35 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (455.24 KB, patch)
2013-01-15 22:21 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-01-15 18:35:09 PST
Created attachment 182896 [details] Patch
Benjamin Poulain
Comment 2 2013-01-15 21:19:56 PST
Comment on attachment 182896 [details] Patch Only moving the files I assume? No need for rebaseline of your WebKit2 layout test results?
Gyuyoung Kim
Comment 3 2013-01-15 21:21:10 PST
(In reply to comment #2) > (From update of attachment 182896 [details]) > Only moving the files I assume? > > No need for rebaseline of your WebKit2 layout test results? Let me check it before landing. Thanks.
Gyuyoung Kim
Comment 4 2013-01-15 21:21:36 PST
(In reply to comment #2) > (From update of attachment 182896 [details]) > Only moving the files I assume? Yes, right. Only move the files.
EFL EWS Bot
Comment 5 2013-01-15 21:29:26 PST
Comment on attachment 182896 [details] Patch Attachment 182896 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15905247
Gyuyoung Kim
Comment 6 2013-01-15 22:21:07 PST
Created attachment 182919 [details] Patch for landing
WebKit Review Bot
Comment 7 2013-01-15 22:28:47 PST
Attachment 182919 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/PlatformEfl.cmake', u..." exit_code: 1 Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_focus.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 8 2013-01-16 00:41:10 PST
Comment on attachment 182919 [details] Patch for landing I don't want to touch other nits because this patch is just to move DefaultTheme place. And also, I think this patch won't influence on layout test result.
WebKit Review Bot
Comment 9 2013-01-16 02:18:07 PST
Comment on attachment 182919 [details] Patch for landing Clearing flags on attachment: 182919 Committed r139858: <http://trac.webkit.org/changeset/139858>
WebKit Review Bot
Comment 10 2013-01-16 02:18:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.