Summary: | [EFL] Move 'DefaultTheme' folder to WebCore/platform/efl | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, eric.carlson, feature-media-reviews, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-01-15 18:33:03 PST
Created attachment 182896 [details]
Patch
Comment on attachment 182896 [details]
Patch
Only moving the files I assume?
No need for rebaseline of your WebKit2 layout test results?
(In reply to comment #2) > (From update of attachment 182896 [details]) > Only moving the files I assume? > > No need for rebaseline of your WebKit2 layout test results? Let me check it before landing. Thanks. (In reply to comment #2) > (From update of attachment 182896 [details]) > Only moving the files I assume? Yes, right. Only move the files. Comment on attachment 182896 [details] Patch Attachment 182896 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15905247 Created attachment 182919 [details]
Patch for landing
Attachment 182919 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/PlatformEfl.cmake', u..." exit_code: 1
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_focus.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5]
Total errors found: 1 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 182919 [details]
Patch for landing
I don't want to touch other nits because this patch is just to move DefaultTheme place. And also, I think this patch won't influence on layout test result.
Comment on attachment 182919 [details] Patch for landing Clearing flags on attachment: 182919 Committed r139858: <http://trac.webkit.org/changeset/139858> All reviewed patches have been landed. Closing bug. |