Bug 106951

Summary: [chromium] Make new-style page scale work with fixed layout
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, cjhopman, danakj, jamesr, trchen, wangxianzhu, webkit.review.bot, wjmaclean
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexandre Elias
Reported 2013-01-15 15:44:02 PST
[chromium] Make new-style page scale work with fixed layout
Attachments
Patch (17.15 KB, patch)
2013-01-15 15:54 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (17.13 KB, patch)
2013-01-16 11:58 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (17.74 KB, patch)
2013-01-16 21:33 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2013-01-15 15:54:08 PST
Created attachment 182864 [details] Patch
Alexandre Elias
Comment 2 2013-01-15 15:55:36 PST
Chromium side of this change at: https://codereview.chromium.org/11958004/
Alexandre Elias
Comment 3 2013-01-16 11:58:43 PST
Created attachment 183016 [details] Patch Change updateLayerTreeViewport layoutViewportSize to include desktop-style scrollbars
Alexandre Elias
Comment 4 2013-01-16 21:33:18 PST
Created attachment 183117 [details] Patch Bring back relayout in didChangeContentsSize, still needed
Adam Barth
Comment 5 2013-01-16 21:42:51 PST
Comment on attachment 183117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183117&action=review I'm not able to verify every detail of this patch, but this definitely looks like an improvement. > Source/WebKit/chromium/ChangeLog:13 > + - dispatchViewportPropertiesDidChange() now works entirely with DIP > + pixels instead of physical pixels, and is made compatible with > + separating deviceScaleFactor from pageScaleFactor. Great!
WebKit Review Bot
Comment 6 2013-01-17 12:27:51 PST
Comment on attachment 183117 [details] Patch Clearing flags on attachment: 183117 Committed r140025: <http://trac.webkit.org/changeset/140025>
WebKit Review Bot
Comment 7 2013-01-17 12:27:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.