Bug 106947

Summary: Rename RenderLayerBacking's m_containmentLayer to m_childContainmentLayer to better describe its purpose
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Simon Fraser (smfr)
Reported 2013-01-15 15:04:44 PST
Rename RenderLayerBacking's m_containmentLayer to m_childContainmentLayer to better describe its purpose
Attachments
Patch (9.04 KB, patch)
2013-01-15 15:06 PST, Simon Fraser (smfr) 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-01-15 15:06:12 PST
Created attachment 182852 [details] Patch
Darin Adler
Comment 2 2013-01-15 15:13:24 PST
Comment on attachment 182852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182852&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:301 > + m_ancestorClippingLayer = nullptr; This looks like a small related bug fix, not a renaming of m_containmentLayer.
Simon Fraser (smfr)
Comment 3 2013-01-15 15:18:39 PST
http://trac.webkit.org/changeset/139797
Simon Fraser (smfr)
Comment 4 2013-01-15 15:28:55 PST
(In reply to comment #2) > (From update of attachment 182852 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182852&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:301 > > + m_ancestorClippingLayer = nullptr; > > This looks like a small related bug fix, not a renaming of m_containmentLayer. Indeed it was; noticed that this wasn't getting cleared. I should have mentioned it in the changelog.
Note You need to log in before you can comment on or make changes to this bug.