[V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize()

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Kentaro Hara]

This is one of steps to remove optional Isolate parameters.

[Kentaro Hara]

Created attachment 182792 [details]
Patch

[Adam Barth]

Comment on attachment 182792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182792&action=review

> Source/WebCore/bindings/v8/SerializedScriptValue.h:88
> +    ScriptValue deserializeForInspector(ScriptState*);
> +    ScriptValue deserializeForInspector(ScriptState*, v8::Isolate*);

We should put the Isolate into ScriptState instead of passing them separately.  Everyone who takes a ScriptState is going to need an isolate.

[Kentaro Hara]

Created attachment 182925 [details]
patch for landing

[Kentaro Hara]

(In reply to comment #2)
> We should put the Isolate into ScriptState instead of passing them separately.  Everyone who takes a ScriptState is going to need an isolate.

Done. Thanks!

[Kentaro Hara]

We might want to implement v8::Context::GetIsolate(). At entry points from WebCore, we have a Frame or a ScriptExecutionContext, which can be converted to a v8::Context. So once v8::Context::GetIsolate() is exposed, we can get an Isolate without calling v8::Isolate::GetCurrent(). I'm implementing v8::Context::GetIsolate().

[Kentaro Hara]

(In reply to comment #5)
> I'm implementing v8::Context::GetIsolate().

The V8 patch is here: https://chromiumcodereview.appspot.com/11968011/

[WebKit Review Bot]

Comment on attachment 182925 [details]
patch for landing

Clearing flags on attachment: 182925

Committed r139854: <http://trac.webkit.org/changeset/139854>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.