Bug 106912

Summary: IndexedDB: Remove dependency on IDBKey type from IDLs
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dgrogan, haraken, japhet, michael, ojan.autocc, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97375    
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2013-01-15 09:03:53 PST
IndexedDB: Remove dependency on IDBKey type from IDLs
Attachments
Patch (50.18 KB, patch)
2013-01-15 09:13 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (50.14 KB, patch)
2013-01-16 16:42 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2013-01-15 09:13:59 PST
Created attachment 182788 [details] Patch
Joshua Bell
Comment 2 2013-01-15 09:17:09 PST
See http://wkbug.com/97375 for more context. This is the preamble to removing special cases for IDBKey from WebKitIDL (code generators, custom binding code, etc). On the one hand this gets us closer to having WebKitIDL match WebIDL - "IDBKey" is replaced by "any" in our IDL files. On the other, this is more code at many of the method implementations, violating DRY.
Joshua Bell
Comment 3 2013-01-15 09:17:31 PST
dgrogan@, alecflett@ - can you guys take a preliminary look?
Joshua Bell
Comment 4 2013-01-16 16:42:40 PST
Created attachment 183060 [details] Patch
Joshua Bell
Comment 5 2013-01-16 16:42:59 PST
New patch is just a rebase, and I wanted to get the bots to give it a try.
Alec Flett
Comment 6 2013-01-18 16:27:44 PST
Comment on attachment 183060 [details] Patch lgtm
Joshua Bell
Comment 7 2013-01-18 16:28:44 PST
haraken@ - can you take a look?
Kentaro Hara
Comment 8 2013-01-19 01:49:02 PST
Comment on attachment 183060 [details] Patch LGTM
WebKit Review Bot
Comment 9 2013-01-22 13:23:04 PST
Comment on attachment 183060 [details] Patch Clearing flags on attachment: 183060 Committed r140457: <http://trac.webkit.org/changeset/140457>
WebKit Review Bot
Comment 10 2013-01-22 13:23:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.