Bug 106907

Summary: [chromium] add title text direction attribute to TestRunner
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, leviw, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

jochen
Reported 2013-01-15 07:54:46 PST
[chromium] add title text direction attribute to TestRunner
Attachments
Patch (8.75 KB, patch)
2013-01-15 07:55 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.82 KB, patch)
2013-01-15 13:02 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (8.80 KB, patch)
2013-01-16 00:30 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-01-15 07:55:02 PST
Created attachment 182775 [details] Patch
WebKit Review Bot
Comment 2 2013-01-15 07:58:27 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
jochen
Comment 3 2013-01-15 13:02:48 PST
Created attachment 182834 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-01-15 13:36:24 PST
Comment on attachment 182834 [details] Patch for landing Clearing flags on attachment: 182834 Committed r139779: <http://trac.webkit.org/changeset/139779>
WebKit Review Bot
Comment 5 2013-01-15 13:36:28 PST
All reviewed patches have been landed. Closing bug.
Levi Weintraub
Comment 6 2013-01-15 14:49:18 PST
Broke the build. Rolled out in http://trac.webkit.org/changeset/139795. It looks like WebTextDirection.h was left out of the checkin.
jochen
Comment 7 2013-01-16 00:28:20 PST
(In reply to comment #6) > Broke the build. Rolled out in http://trac.webkit.org/changeset/139795. It looks like WebTextDirection.h was left out of the checkin. Thanks for rolling out. Just for the record, the header is not missing, but TestRunner public API headers need to specify the full path to WebKit public API headers.
jochen
Comment 8 2013-01-16 00:30:46 PST
Created attachment 182930 [details] Patch
WebKit Review Bot
Comment 9 2013-01-16 01:43:58 PST
Comment on attachment 182930 [details] Patch Clearing flags on attachment: 182930 Committed r139850: <http://trac.webkit.org/changeset/139850>
WebKit Review Bot
Comment 10 2013-01-16 01:44:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.