Bug 106899

Summary: [Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, haraken, jamesr, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106829    
Attachments:
Description Flags
Patch none

Description Mark Pilgrim (Google) 2013-01-15 06:07:56 PST
[Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
Comment 1 Mark Pilgrim (Google) 2013-01-15 06:08:38 PST
Created attachment 182749 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-15 06:11:12 PST
Attachment 182749 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp:32:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp:213:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp:215:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2013-01-15 12:25:39 PST
Comment on attachment 182749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182749&action=review

This looks good.  All these files have minor style issues, but I think you're right not to chase them.

> Source/WebCore/platform/network/chromium/SocketStreamHandleInternal.h:42
> +

Usually we skip these blank lines for forward declarations.

> Source/WebCore/platform/network/chromium/SocketStreamHandleInternal.h:46
> +

This one too
Comment 4 WebKit Review Bot 2013-01-15 12:47:43 PST
Comment on attachment 182749 [details]
Patch

Clearing flags on attachment: 182749

Committed r139774: <http://trac.webkit.org/changeset/139774>
Comment 5 WebKit Review Bot 2013-01-15 12:47:47 PST
All reviewed patches have been landed.  Closing bug.