Bug 106898

Summary: [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
Product: WebKit Reporter: Florin Malita <fmalita>
Component: Layout and RenderingAssignee: Florin Malita <fmalita>
Status: RESOLVED FIXED    
Severity: Normal CC: junov, robertphillips, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Composited rounded rect shows opaque black corners.
none
Patch none

Florin Malita
Reported 2013-01-15 06:04:21 PST
Created attachment 182748 [details] Composited rounded rect shows opaque black corners. PlatformContextSkia::drawRRect (added http://trac.webkit.org/changeset/139191) should call didDrawBounded, not didDrawRect.
Attachments
Composited rounded rect shows opaque black corners. (172 bytes, text/html)
2013-01-15 06:04 PST, Florin Malita 		no flags
Details
Patch (11.72 KB, patch)
2013-01-15 08:19 PST, Florin Malita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Florin Malita
Comment 1 2013-01-15 08:19:09 PST
Created attachment 182780 [details] Patch
Stephen White
Comment 2 2013-01-15 08:20:38 PST
Comment on attachment 182780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182780&action=review > LayoutTests/platform/chromium/TestExpectations:4219 > +# Needs platform-specific results Is there a way to do this as a reftest? Maybe the same thing, but without the translateZ, so it uses the software path?
Florin Malita
Comment 3 2013-01-15 08:22:48 PST
Comment on attachment 182780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182780&action=review >> LayoutTests/platform/chromium/TestExpectations:4219 >> +# Needs platform-specific results > > Is there a way to do this as a reftest? Maybe the same thing, but without the translateZ, so it uses the software path? I did try a reftest first, but unfortunately the compositor seems to affect the corners' anti-aliasing.
Stephen White
Comment 4 2013-01-15 08:23:48 PST
(In reply to comment #3) > (From update of attachment 182780 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182780&action=review > > >> LayoutTests/platform/chromium/TestExpectations:4219 > >> +# Needs platform-specific results > > > > Is there a way to do this as a reftest? Maybe the same thing, but without the translateZ, so it uses the software path? > > I did try a reftest first, but unfortunately the compositor seems to affect the corners' anti-aliasing. Ahh, of course.
Stephen White
Comment 5 2013-01-15 08:24:07 PST
Comment on attachment 182780 [details] Patch Looks good, bots willing. r=me
Florin Malita
Comment 6 2013-01-15 08:40:17 PST
Comment on attachment 182780 [details] Patch Thanks, Stephen.
WebKit Review Bot
Comment 7 2013-01-15 08:59:21 PST
Comment on attachment 182780 [details] Patch Clearing flags on attachment: 182780 Committed r139745: <http://trac.webkit.org/changeset/139745>
WebKit Review Bot
Comment 8 2013-01-15 08:59:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.