Bug 106893

Summary: Web Inspector: refactor DefaultTextEditor's paintLine method
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Andrey Lushnikov 2013-01-15 05:20:59 PST 
Refactor DefaultTextEditor's paintLine method: separate its range rendering functionality into a subroutine. It will be useful in future development.
Comment 1 Andrey Lushnikov 2013-01-15 05:48:41 PST 
Created attachment 182744 [details]
Patch
Comment 2 Andrey Lushnikov 2013-01-15 06:15:34 PST 
Created attachment 182750 [details]
Patch
Comment 3 WebKit Review Bot 2013-01-15 07:51:38 PST 
Comment on attachment 182750 [details]
Patch

Clearing flags on attachment: 182750

Committed r139740: <http://trac.webkit.org/changeset/139740>
Comment 4 WebKit Review Bot 2013-01-15 07:51:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Vsevolod Vlasov 2013-01-15 08:03:18 PST 
This patch made closure compiler fail.

Source/WebCore/inspector/front-end/DefaultTextEditor.js:1893: WARNING - Property token never defined on {cssClass: string, endColumn: number, startColumn: number}
            var cssClass = ranges[i].token ? "webkit-" + ranges[i].token : "";