| Summary: | Group all request parameters which are used to match CSS Rules into a parameter object. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||
| Component: | CSS | Assignee: | Hayato Ito <hayato> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | allan.jensen, cmarcelo, dglazkov, macpherson, menard, ojan.autocc, webcomponents-bugzilla, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 82169, 89879 | ||||||||
| Attachments: |
|
||||||||
|
Description
Hayato Ito
2013-01-15 01:01:07 PST
Created attachment 182717 [details]
factored. Introduces MatchRequest
Comment on attachment 182717 [details] factored. Introduces MatchRequest View in context: https://bugs.webkit.org/attachment.cgi?id=182717&action=review > Source/WebCore/ChangeLog:3 > + Group all request parameters which is used to match CSS Rules into a one parameter. is used => are used to agree with the plural parameters Also a one parameter => a parameter object "a one" is wrong; "a parameter object" is more specific but at least delete "a", that is "into one parameter" Comment on attachment 182717 [details]
factored. Introduces MatchRequest
Please address Dominic's nits.
Thank you for the review. Let me land the patch afte fixing the ChangeLog. (In reply to comment #2) > (From update of attachment 182717 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182717&action=review > > > Source/WebCore/ChangeLog:3 > > + Group all request parameters which is used to match CSS Rules into a one parameter. > > is used => are used > > to agree with the plural parameters > > Also > > a one parameter => a parameter object > > "a one" is wrong; "a parameter object" is more specific but at least delete "a", that is "into one parameter" Created attachment 182887 [details]
Patch for landing
Comment on attachment 182887 [details] Patch for landing Clearing flags on attachment: 182887 Committed r139817: <http://trac.webkit.org/changeset/139817> All reviewed patches have been landed. Closing bug. |