Bug 106872

Summary: Update GraphicsContext to support winding rule in clip operator for Chromium
Product: WebKit Reporter: Rik Cabanier <cabanier>
Component: WebCore Misc.Assignee: Rik Cabanier <cabanier>
Status: RESOLVED FIXED    
Severity: Normal CC: junov, pdr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 106871    
Bug Blocks: 106188    
Attachments:
Description Flags
Patch
none
Patch none

Description Rik Cabanier 2013-01-14 22:10:44 PST 
Add support for winding operator in chromium codebase
Comment 1 Rik Cabanier 2013-01-17 13:19:57 PST 
Created attachment 183256 [details]
Patch
Comment 2 Justin Novosad 2013-01-17 13:33:10 PST 
Comment on attachment 183256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183256&action=review

> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:361
> +        storage.setFillType(ftype);

I think you mean to set the fill type back to savedFillRule here?  We shouldn't even need to do that since storage is a temp copy, or am I missing something?
Comment 3 Rik Cabanier 2013-01-17 13:39:51 PST 
Created attachment 183262 [details]
Patch
Comment 4 Rik Cabanier 2013-01-17 13:40:58 PST 
(In reply to comment #2)
> (From update of attachment 183256 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183256&action=review
> 
> > Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:361
> > +        storage.setFillType(ftype);
> 
> I think you mean to set the fill type back to savedFillRule here?  We shouldn't even need to do that since storage is a temp copy, or am I missing something?
you're correct. I thought it was somehow set in the platform path.

Fixed in latest patch (+ removed obsolete comment)
Comment 5 Philip Rogers 2013-01-17 19:25:45 PST 
Comment on attachment 183262 [details]
Patch

This patch is straightforward and looks good to me.
Comment 6 Dirk Schulze 2013-01-17 19:30:34 PST 
Comment on attachment 183262 [details]
Patch

Reviewed together with pdr. Looked good for us. r=me
Comment 7 WebKit Review Bot 2013-01-17 20:02:59 PST 
Comment on attachment 183262 [details]
Patch

Clearing flags on attachment: 183262

Committed r140098: <http://trac.webkit.org/changeset/140098>
Comment 8 WebKit Review Bot 2013-01-17 20:03:04 PST 
All reviewed patches have been landed.  Closing bug.