Bug 106872 – Update GraphicsContext to support winding rule in clip operator for Chromium

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Rik Cabanier]

Add support for winding operator in chromium codebase

[Rik Cabanier]

Created attachment 183256 [details]
Patch

[Justin Novosad]

Comment on attachment 183256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183256&action=review

> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:361
> +        storage.setFillType(ftype);

I think you mean to set the fill type back to savedFillRule here?  We shouldn't even need to do that since storage is a temp copy, or am I missing something?

[Rik Cabanier]

Created attachment 183262 [details]
Patch

[Rik Cabanier]

(In reply to comment #2)
> (From update of attachment 183256 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183256&action=review
> 
> > Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:361
> > +        storage.setFillType(ftype);
> 
> I think you mean to set the fill type back to savedFillRule here?  We shouldn't even need to do that since storage is a temp copy, or am I missing something?
you're correct. I thought it was somehow set in the platform path.

Fixed in latest patch (+ removed obsolete comment)

[Philip Rogers]

Comment on attachment 183262 [details]
Patch

This patch is straightforward and looks good to me.

[Dirk Schulze]

Comment on attachment 183262 [details]
Patch

Reviewed together with pdr. Looked good for us. r=me

[WebKit Review Bot]

Comment on attachment 183262 [details]
Patch

Clearing flags on attachment: 183262

Committed r140098: <http://trac.webkit.org/changeset/140098>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.