Bug 106864 – [EFL][WK2] Process single tap using mouse move, down and up event.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Eunmi Lee]

Process single tap gesture of WebKit2 EFL port using WebEvent::GestureSingleTap,
and enable GESTURE_EVENTS to use GestureSingleTap in the WebKit2 EFL if WEBKIT2 and TILED_BACKING_STORE are enabled.

[Eunmi Lee]

Created attachment 182692 [details]
Patch

[Eunmi Lee]

Created attachment 182724 [details]
Patch

Update patch for changed Bug 102643

[Eunmi Lee]

Created attachment 191411 [details]
Patch

Rebased.

[Eunmi Lee]

Created attachment 191646 [details]
Patch

Rebase and add WKViewSendGestureEvent().

[Eunmi Lee]

Created attachment 193495 [details]
Patch

Modified codes to use EFLGestureEvent.

[Eunmi Lee]

Created attachment 193775 [details]
Patch

Rebase and rename EFLGestureEvent to EwkGestureEvent.

[Eunmi Lee]

Created attachment 206055 [details]
Patch

Rebased.

[Chris Dumez]

(In reply to comment #7)
> Created an attachment (id=206055) [details]
> Patch
> 
> Rebased.

The patch does not apply.

[Eunmi Lee]

Created attachment 207625 [details]
Patch

Rebase.

[Eunmi Lee]

Created attachment 208250 [details]
Patch

Rebase.

[Eunmi Lee]

I will update patch because GESTURE_EVENTS will be removed.

[Eunmi Lee]

Created attachment 214552 [details]
Patch

Process single tap using mouse events instead of GestureSingleTap event.

[Chris Dumez]

Comment on attachment 214552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214552&action=review

LGTM % the mouse move which seems a little bit odd. r=me.

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:142
> +    WKViewSendMouseMoveEvent(m_ewkView->wkView(), &mouseMove);

So we need to send a MouseMoveEvent for a single tap? Mouse down then up is not enough?

[Eunmi Lee]

(In reply to comment #13)
> (From update of attachment 214552 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214552&action=review
> 
> LGTM % the mouse move which seems a little bit odd. r=me.
> 
> > Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:142
> > +    WKViewSendMouseMoveEvent(m_ewkView->wkView(), &mouseMove);
> 
> So we need to send a MouseMoveEvent for a single tap? Mouse down then up is not enough?

Thanks for review! (I'm late)
MouseMoveEvent is needed to move the mouse pointer to the clicked location.

[WebKit Commit Bot]

Comment on attachment 214552 [details]
Patch

Clearing flags on attachment: 214552

Committed r159401: <http://trac.webkit.org/changeset/159401>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.