Bug 106856 – Support variables inside -webkit-box-reflect CSS property.

• Component: New Bugs
• Status: RESOLVED FIXED

[Luke Macpherson]

Support variables inside -webkit-box-reflect CSS property.

[Luke Macpherson]

Created attachment 182683 [details]
Patch

[Build Bot]

Comment on attachment 182683 [details]
Patch

Attachment 182683 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15841798

[Luke Macpherson]

Created attachment 182872 [details]
Patch

[Luke Macpherson]

Can anyone review this?

[Tony Chang]

Comment on attachment 182872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182872&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:612
> +    default:
> +        ASSERT_NOT_REACHED();

Remove the default: case so the compiler will ensure we're testing all cases.

> Source/WebCore/css/CSSReflectValue.cpp:41
> +    if (m_mask)
> +        return m_direction->cssText() + ' ' + m_offset->cssText() + ' ' + m_mask->cssText();
> +    return m_direction->cssText() + ' ' + m_offset->cssText();

I would mention in the ChangeLog that you no longer use StringBuilder but this is just as fast because of StringOperators.h and StringConcatenate.h.

> Source/WebCore/css/CSSReflectValue.cpp:49
> +        return m_direction->customSerializeResolvingVariables(variables) + ' ' + m_offset->customSerializeResolvingVariables(variables) + ' ' + m_mask->serializeResolvingVariables(variables);
> +    return m_direction->customSerializeResolvingVariables(variables) + ' ' + m_offset->customSerializeResolvingVariables(variables);

You could mention this in the ChangeLog too.

[Luke Macpherson]

Created attachment 184380 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 184380 [details]
Patch for landing

Clearing flags on attachment: 184380

Committed r140642: <http://trac.webkit.org/changeset/140642>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.