Summary: | [Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominic Cooney <dominicc> | ||||||
Component: | DOM | Assignee: | Dima Gorbik <dgorbik> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dgorbik, eric.carlson, feature-media-reviews, koivisto, webkit-bug-importer, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 7 | ||||||||
Attachments: |
|
Description
Dominic Cooney
2013-01-14 18:31:10 PST
Created attachment 182678 [details]
Proposed fix 0.1
Comment on attachment 182678 [details] Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=182678&action=review > LayoutTests/media/track/track-css-cue-lifetime-expected.txt:20 > RUN(video.currentTime = 1.8000000000000003) This is likely to cause problems on some ports. I suggest rounding the input to one significant digit, something like: run("video.currentTime = " + (Math.round((initialTime + seekedCount * step)* 10) / 10)) Created attachment 182681 [details]
Proposed fix 0.2
(In reply to comment #2) > (From update of attachment 182678 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182678&action=review > > > LayoutTests/media/track/track-css-cue-lifetime-expected.txt:20 > > RUN(video.currentTime = 1.8000000000000003) > > This is likely to cause problems on some ports. I suggest rounding the input to one significant digit, something like: > > run("video.currentTime = " + (Math.round((initialTime + seekedCount * step)* 10) / 10)) I have though about this. I think this should be dependent only on JSC code. But still it could be good to have rounded values. Comment on attachment 182681 [details]
Proposed fix 0.2
I am not a reviewer, but this looks good to me.
Comment on attachment 182681 [details] Proposed fix 0.2 Clearing flags on attachment: 182681 Committed r139737: <http://trac.webkit.org/changeset/139737> All reviewed patches have been landed. Closing bug. |