Bug 106853

Summary:

[Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562

Product:

WebKit

Reporter:

Dominic Cooney <dominicc>

Component:

DOM

Assignee:

Dima Gorbik <dgorbik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dgorbik, eric.carlson, feature-media-reviews, koivisto, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Proposed fix 0.1	none
Proposed fix 0.2	none

Dominic Cooney

Reported 2013-01-14 18:31:10 PST

See this test on the flakiness dashboard here: <http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-css-cue-lifetime.html> This test is noted to be slow on other platforms, but it started timing out reliably on Chromium Win7 dbg in this range: <http://trac.webkit.org/log/?verbose=on&rev=139564&stop_rev=139562> r139562 looks like a likely candidate.

Attachments
Proposed fix 0.1 (7.36 KB, patch) 2013-01-14 18:49 PST, Dima Gorbik	no flags	Details Formatted Diff Diff
Proposed fix 0.2 (7.79 KB, patch) 2013-01-14 19:16 PST, Dima Gorbik	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dima Gorbik

Comment 1 2013-01-14 18:49:16 PST

Created attachment 182678 [details] Proposed fix 0.1

Eric Carlson

Comment 2 2013-01-14 19:06:25 PST

Comment on attachment 182678 [details] Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=182678&action=review > LayoutTests/media/track/track-css-cue-lifetime-expected.txt:20 > RUN(video.currentTime = 1.8000000000000003) This is likely to cause problems on some ports. I suggest rounding the input to one significant digit, something like: run("video.currentTime = " + (Math.round((initialTime + seekedCount * step)* 10) / 10))

Dima Gorbik

Comment 3 2013-01-14 19:16:25 PST

Created attachment 182681 [details] Proposed fix 0.2

Dima Gorbik

Comment 4 2013-01-14 19:18:51 PST

(In reply to comment #2) > (From update of attachment 182678 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182678&action=review > > > LayoutTests/media/track/track-css-cue-lifetime-expected.txt:20 > > RUN(video.currentTime = 1.8000000000000003) > > This is likely to cause problems on some ports. I suggest rounding the input to one significant digit, something like: > > run("video.currentTime = " + (Math.round((initialTime + seekedCount * step)* 10) / 10)) I have though about this. I think this should be dependent only on JSC code. But still it could be good to have rounded values.

Dominic Cooney

Comment 5 2013-01-14 22:31:22 PST

Comment on attachment 182681 [details] Proposed fix 0.2 I am not a reviewer, but this looks good to me.

WebKit Review Bot

Comment 6 2013-01-15 07:13:37 PST

Comment on attachment 182681 [details] Proposed fix 0.2 Clearing flags on attachment: 182681 Committed r139737: <http://trac.webkit.org/changeset/139737>

WebKit Review Bot

Comment 7 2013-01-15 07:13:40 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2013-01-15 10:58:50 PST

<rdar://problem/13017237>

Note You need to log in before you can comment on or make changes to this bug.