Bug 106843

Summary: [Sub pixel layout] RTL cells with padding wraps
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jchaffraix, leviw, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Emil A Eklund
Reported 2013-01-14 16:44:14 PST
At certain zoom levels table cells with padding wraps for rtl content. Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=141035
Attachments
Patch (4.23 KB, patch)
2013-01-14 16:47 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.33 KB, patch)
2013-01-15 15:11 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2013-01-14 16:47:39 PST
Created attachment 182661 [details] Patch
Levi Weintraub
Comment 2 2013-01-15 14:59:59 PST
Comment on attachment 182661 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182661&action=review > Source/WebCore/rendering/RenderTable.h:198 > + virtual LayoutUnit paddingEnd() const OVERRIDE { return static_cast<int>(RenderBlock::paddingEnd()); } > + virtual LayoutUnit paddingStart() const OVERRIDE { return static_cast<int>(RenderBlock::paddingStart()); } Please add a one-liner comment explaining why this is done.
Emil A Eklund
Comment 3 2013-01-15 15:11:53 PST
Created attachment 182853 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-01-15 16:16:21 PST
Comment on attachment 182853 [details] Patch for landing Clearing flags on attachment: 182853 Committed r139807: <http://trac.webkit.org/changeset/139807>
WebKit Review Bot
Comment 5 2013-01-15 16:16:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.