| Summary: | [Chromium] Move BlobRegistryProxy into WebCore | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||
| Component: | WebKit Misc. | Assignee: | Mark Pilgrim (Google) <pilgrim> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, fishd, haraken, jamesr, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 106829 | ||||||
| Attachments: |
|
||||||
|
Description
Mark Pilgrim (Google)
2013-01-14 14:46:37 PST
Created attachment 182631 [details]
Patch
Comment on attachment 182631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182631&action=review I think this is fine for a first patch. There's more cleanup we can do to better integrate BlobRegistryProxy with BlobRegistryImpl > Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp:48 > +// We are part of the WebKit implementation. > +using namespace WebKit; As in the other patch, it would be better to remove this using directive and be explicit about when we're using things in the WebKit namespace. > Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp:52 > +BlobRegistry& blobRegistry() It looks like this function is declared in Source/WebCore/platform/network/BlobRegistry.h. I wonder if we should put this function in Source/WebCore/platform/network/BlobRegistryImpl.cpp? Comment on attachment 182631 [details] Patch Clearing flags on attachment: 182631 Committed r139698: <http://trac.webkit.org/changeset/139698> All reviewed patches have been landed. Closing bug. Filed Bug 106859 for WebKit prefix. |